Skip to content

refactor: change from serialising a u64 to i64 #3065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JosephLenton wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

refactor: change from serialising a u64 to i64 #3065

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions crates/iceberg/src/spec/manifest_list/_serde.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ pub(super) struct ManifestFileV3 {
pub deleted_rows_count: i64,
pub partitions: Option<Vec<FieldSummary>>,
pub key_metadata: Option<ByteBuf>,
pub first_row_id: Option<u64>,
pub first_row_id: Option<i64>,
}

impl ManifestFileV3 {
Expand All @@ -215,7 +215,7 @@ impl ManifestFileV3 {
deleted_rows_count: Some(self.deleted_rows_count.try_into()?),
partitions: self.partitions,
key_metadata: self.key_metadata.map(|b| b.into_vec()),
first_row_id: self.first_row_id,
first_row_id: self.first_row_id.map(|n| n.try_into()).transpose()?,
};

Ok(manifest_file)
Expand Down Expand Up @@ -372,7 +372,7 @@ impl TryFrom<ManifestFile> for ManifestFileV3 {
.try_into()?,
partitions: value.partitions,
key_metadata,
first_row_id: value.first_row_id,
first_row_id: value.first_row_id.map(|n| n.try_into()).transpose()?,
})
}
}
Expand Down
Loading