fix(rest): send the requested format version when creating a table - #3055
Open
xanderbailey wants to merge 3 commits into
Open
fix(rest): send the requested format version when creating a table#3055xanderbailey wants to merge 3 commits into
xanderbailey wants to merge 3 commits into
Conversation
`TableCreation::format_version` was dropped on the floor by the REST create path: the create request has no format-version field, so the value has to travel as the `format-version` table property, and the catalog never set it. Every table came back at whatever version the server defaulted to. Send it from the field, and reject a caller-supplied `format-version` property. It is a reserved property, so `TableMetadataBuilder` already rejects it for local catalogs; silently overriding it here would instead turn a request for one version into a table at another.
xanderbailey
commented
Aug 23, 2026
Comment on lines
+1139
to
+1147
| if properties.contains_key(TableProperties::PROPERTY_FORMAT_VERSION) { | ||
| return Err(Error::new( | ||
| ErrorKind::DataInvalid, | ||
| format!( | ||
| "Table properties should not contain reserved properties, but got: [{}]. Set `TableCreation::format_version` instead", | ||
| TableProperties::PROPERTY_FORMAT_VERSION | ||
| ), | ||
| )); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This is a break technically but I think it's a legitimate break that we can document in the upgrade docs for 0.11.0
We could also allow the property IF it matches the format_version provided?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
TableCreation::format_versionis ignored when creating a table using the Iceberg REST catalog interface #2923What changes are included in this PR?
TableCreation::format_versionwas dropped on the floor by the REST create path: the create request has no format-version field, so the value has to travel as theformat-versiontable property, and the catalog never set it. Every table came back at whatever version the server defaulted to.Send it from the field, and reject a caller-supplied
format-versionproperty. It is a reserved property, soTableMetadataBuilderalready rejects it for local catalogs; silently overriding it here would instead turn a request for one version into a table at another.Are these changes tested?
AI Disclosure