-
Notifications
You must be signed in to change notification settings - Fork 549
feat(datafusion) Add snapshot_id parameter to pin table reads #2862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
NoahKusaba
wants to merge
22
commits into
apache:main
from
NoahKusaba:feature/datafusion-snapshot-id
Closed
Changes from 5 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
a43741b
init
NoahKusaba 63e9b61
merge tests
NoahKusaba 5a8e388
Merge branch 'main' into feature/datafusion-snapshot-id
NoahKusaba 60b5c1a
cleanup
NoahKusaba 4fe1ebb
make tests assert batch
NoahKusaba 345b0b3
Merge branch 'main' into feature/datafusion-snapshot-id
NoahKusaba b97ce72
fix read-insert-read snapshot
NoahKusaba f49bf31
Merge branch 'main' into feature/datafusion-snapshot-id
NoahKusaba edb11db
Merge branch 'main' into feature/datafusion-snapshot-id
NoahKusaba 3e42a9e
fix schema version error
NoahKusaba a9215c7
fix test
NoahKusaba a29b460
Merge branch 'main' into feature/datafusion-snapshot-id
NoahKusaba cb218e5
make snapshot_arrow_schema public
NoahKusaba 9d92b11
reload table in with_snapshot_id, get rid of Table Parameter
NoahKusaba bd0c036
Merge branch 'main' into feature/datafusion-snapshot-id
NoahKusaba fe72134
simplify tests
NoahKusaba bfd3aca
Merge branch 'main' into feature/datafusion-snapshot-id
NoahKusaba 43e123d
Merge branch 'main' into feature/datafusion-snapshot-id
NoahKusaba 4e25485
Merge branch 'main' into feature/datafusion-snapshot-id
NoahKusaba 1c71c7d
Merge branch 'main' into feature/datafusion-snapshot-id
NoahKusaba 1258792
Merge branch 'main' into feature/datafusion-snapshot-id
NoahKusaba 97e24f5
Merge branch 'main' into feature/datafusion-snapshot-id
NoahKusaba File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reloads table metadata from the catalog purely to validate the snapshot and recompute the schema, and
scan()(line 178-183 below) reloads again right after. That's two catalog round trips before a query that needs one, and it makes what reads like a builder setter into a fallible, async network call. Per the comment above it, this cost exists specifically to handle providers the catalog hands out and caches across calls. Is that caching concern this type's to own, or should the reload-for-freshness logic live wherever the caching actually happens (the Ballista scheduler side, by the description upthread)?