Skip to content

Update logic for retrieving version information for a JDBC driver #7205 #7206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nadment wants to merge 1 commit into
base: main
Choose a base branch
from
+31 −10
Open

Update logic for retrieving version information for a JDBC driver #7205 #7206

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 31 additions & 10 deletions ui/src/main/java/org/apache/hop/ui/core/database/DatabaseMetaEditor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

package org.apache.hop.ui.core.database;

import java.sql.Driver;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collections;
Expand Down Expand Up @@ -71,6 +72,7 @@
import org.eclipse.swt.widgets.Text;
import org.eclipse.swt.widgets.ToolBar;
import org.eclipse.swt.widgets.ToolItem;
import org.jspecify.annotations.Nullable;

@GuiPlugin(description = "This is the editor for database connection metadata")
/**
Expand Down Expand Up @@ -1188,26 +1190,45 @@ public void getWidgetsContent(DatabaseMeta meta) {
meta.setSshTunnelPassphrase(wSshTunnelPassphrase.getText());
}

/** Update JDBC driver information and version */
/** Updates the displayed driver information, including the driver name and version. */
protected void updateDriverInfo() {
String driverName;
String driverVersion = null;
try {
DatabaseMeta databaseMeta = new DatabaseMeta();
this.getWidgetsContent(databaseMeta);

wDriverInfo.setText("");
String driverName = databaseMeta.getDriverClass(getVariables());
driverName = databaseMeta.getDriverClass(getVariables());
if (!Utils.isEmpty(driverName)) {
ClassLoader classLoader = databaseMeta.getIDatabase().getClass().getClassLoader();
Class<?> driver = classLoader.loadClass(driverName);
Class<? extends Driver> driverClass =
classLoader.loadClass(driverName).asSubclass(Driver.class);
driverVersion = getDriverVersion(driverClass);
}
} catch (Exception e) {
driverName = "No driver installed";
}

if (driver.getPackage().getImplementationVersion() != null) {
driverName = driverName + " (" + driver.getPackage().getImplementationVersion() + ")";
}
wDriverInfo.setText(driverName + (driverVersion != null ? " (" + driverVersion + ")" : ""));
}

wDriverInfo.setText(driverName);
}
/**
* Retrieves the version information for the specified JDBC driver class.
*
* @param driverClass The JDBC driver class for which to retrieve the version information.
* @return The driver version as a string, or null if the version cannot be determined.
*/
private static @Nullable String getDriverVersion(Class<? extends Driver> driverClass) {
String version = driverClass.getPackage().getImplementationVersion();
if (version != null) {
return version;
}
try {
Driver driver = driverClass.getDeclaredConstructor().newInstance();
return driver.getMajorVersion() + "." + driver.getMinorVersion();
} catch (Exception e) {
wDriverInfo.setText("No driver installed");
// Ignore - version could not be determined
return null;
}
}

Expand Down
Loading