Rework janino scanner to make it lighter in mem and faster#7190
Open
rmannibucau wants to merge 1 commit into
Open
Rework janino scanner to make it lighter in mem and faster#7190rmannibucau wants to merge 1 commit into
rmannibucau wants to merge 1 commit into
Conversation
7a7a450 to
833ad77
Compare
833ad77 to
33ed904
Compare
Contributor
|
awesome work! will review and merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean install apache-rat:checkto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.git rebase -i.addresses #123), if applicable.To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
--
some figures using a small jmh benchmark and just a prefiltering optimization - we can still do filtering on the fly on jars to avoid to load them all in mem but after the jar filtering it is less impacting, in terms of mem we can save dozens of megs (~50M on a test app)
the code of the bench:
WARNING: there are two known differences with guava scanning: