Skip to content

[GLUTEN-11921] Support NullType Parquet read/write #12056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wecharyu wants to merge 1 commit into
base: main
Choose a base branch
from
+37 −1
Open

[GLUTEN-11921] Support NullType Parquet read/write #12056

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion gluten-ut/spark41/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -547,7 +547,6 @@ class VeloxTestSettings extends BackendTestSettings {
// TODO: fix on Spark-4.1
.excludeByPrefix("SPARK-53535") // see https://issues.apache.org/jira/browse/SPARK-53535
.excludeByPrefix("vectorized reader: missing all struct fields")
.excludeByPrefix("SPARK-54220") // https://issues.apache.org/jira/browse/SPARK-54220
enableSuite[GlutenParquetV1PartitionDiscoverySuite]
enableSuite[GlutenParquetV2PartitionDiscoverySuite]
enableSuite[GlutenParquetProtobufCompatibilitySuite]
Expand Down
37 changes: 37 additions & 0 deletions .../test/scala/org/apache/spark/sql/execution/datasources/parquet/GlutenParquetIOSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,51 @@
package org.apache.spark.sql.execution.datasources.parquet

import org.apache.spark.sql._
import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.sql.types.{IntegerType, StringType, StructType}

/** A test suite that tests basic Parquet I/O. */
class GlutenParquetIOSuite extends ParquetIOSuite with GlutenSQLTestsBaseTrait {
override def testNameBlackList: Seq[String] =
Copy link
Copy Markdown
Member

@philo-he philo-he May 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep this test excluded in VeloxTestSettings.scala? That way, it won't affect other backends' test enabling controls.

Copy link
Copy Markdown
Member

@philo-he philo-he May 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testGluten("SPARK-54220: xxx will add a prefix into the test name. I assume excludeByPrefix("SPARK-54220") will not exclude this test variant.

Seq("SPARK-54220: vectorized reader: missing all struct fields, struct with NullType only")

override protected def testFile(fileName: String): String = {
getWorkspaceFilePath("sql", "core", "src", "test", "resources").toString + "/" + fileName
}

override protected def readResourceParquetFile(name: String): DataFrame = {
spark.read.parquet(testFile(name))
}

testGluten(
"SPARK-54220: vectorized reader: missing all struct fields, struct with NullType only") {
val data = Seq(
Tuple1((null, null)),
Tuple1((null, null)),
Tuple1(null)
)
val readSchema = new StructType().add(
"_1",
new StructType()
.add("_3", IntegerType, nullable = true)
.add("_4", StringType, nullable = true),
nullable = true)
val expectedAnswer = Row(Row(null, null)) :: Row(Row(null, null)) :: Row(null) :: Nil

withParquetFile(data) {
file =>
for (offheapEnabled <- Seq(true, false)) {
withSQLConf(
SQLConf.PARQUET_VECTORIZED_READER_NESTED_COLUMN_ENABLED.key -> "true",
SQLConf.LEGACY_PARQUET_RETURN_NULL_STRUCT_IF_ALL_FIELDS_MISSING.key -> "false",
SQLConf.COLUMN_VECTOR_OFFHEAP_ENABLED.key -> offheapEnabled.toString
) {
withAllParquetReaders {
val df = spark.read.schema(readSchema).parquet(file)
checkAnswer(df, expectedAnswer)
}
}
}
}
}
}
Loading