[server]: remove orphan files and directories when tablet starts up#3388
Open
gyang94 wants to merge 1 commit into
Open
[server]: remove orphan files and directories when tablet starts up#3388gyang94 wants to merge 1 commit into
gyang94 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #3387
Brief change log
Two changes, one in each cleanup path:
1.
ReplicaManager: handleNoneReplicawithdeleteLocal=trueWhen the
NoneReplicabranch receivesdeleteLocal=true, look up the bucket inLogManager.currentLogs. If present, the log tablet was loaded at startup but never registered inallReplicas— it is an orphan. Drop the log vialogManager.dropLog(), delete the sibling KV tablet directory (viakvManager.dropKv()if loaded, otherwise directFileUtils.deleteDirectory), update disk usage accounting, and record the parent directory for empty-dir cleanup.This handles the partition deletion scenario.
2.
LogManager: clean up empty parent directories inSchemaNotExistExceptionhandlerAfter the existing handler deletes
log-N/andkv-N/, check whether the parent directory is empty and delete it. For partitioned tables, also check the grandparent (table directory). For non-partitioned tables, the grandparent is the database directory and must NOT be deleted. This is safe under parallelloadAllLogsexecution —deleteDirectoryQuietlytolerates races.This handles the table deletion scenario.
Tests
API and Format
Documentation