-
Notifications
You must be signed in to change notification settings - Fork 547
[Flink] Kvscan flink integration #3383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
polyzos
wants to merge
13
commits into
apache:main
Choose a base branch
from
polyzos:kvscan-flink-integration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 10 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
3e4cc49
[flink] Add KvBatchSplit for server-side KV scan integration
polyzos 8269b6d
[flink] Emit KvBatchSplit for bounded PK reads without snapshot
polyzos d7c4e0a
[flink] Wire KvBatchSplit into FlinkSourceSplitReader
polyzos 88e7fb2
[flink] Gate bounded KvBatchSplit emission behind master switch
polyzos b48c90a
[flink] redundand code cleanup and test
polyzos 00afd9e
[flink] add a test with the client
polyzos ecdb181
[flink] add documentation
polyzos 98d8c9f
[flink] small improvements and tests
polyzos 4f5e693
[flink] add more tests
polyzos 0de049a
[flink] fix formatting issue
polyzos 113bc4e
[flink] address copilot comments
polyzos e3c9db5
[flink] change message back to datalake enabled
polyzos eec665b
[flink] fix broken test
polyzos File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65 changes: 65 additions & 0 deletions
65
...nk/fluss-flink-common/src/main/java/org/apache/fluss/flink/source/split/KvBatchSplit.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.fluss.flink.source.split; | ||
|
|
||
| import org.apache.fluss.metadata.TableBucket; | ||
|
|
||
| import javax.annotation.Nullable; | ||
|
|
||
| /** | ||
| * A bounded split that reads the full primary-key state of a bucket via the server-side KV scan | ||
| * (FIP-17). Emitted by the enumerator when a primary-key table has no KV snapshot file available | ||
| * for the bucket and the source is running in bounded mode. | ||
| * | ||
| * <p>This split has no resumable position: on Flink task restart the bucket is rescanned from | ||
| * scratch. Snapshot isolation is provided by the server (a consistent point-in-time view of the | ||
| * RocksDB state at the moment {@code ScanKv} opens the scan), but the client cannot resume an | ||
| * expired or invalidated session, so progress is not checkpointed. | ||
| * | ||
| * <p>Unlike {@link HybridSnapshotLogSplit}, this split has no log handoff phase: when the bucket is | ||
| * drained the split is marked finished. | ||
| */ | ||
| public class KvBatchSplit extends SourceSplitBase { | ||
|
|
||
| private static final String KV_BATCH_SPLIT_PREFIX = "kv-batch-"; | ||
|
|
||
| public KvBatchSplit(TableBucket tableBucket, @Nullable String partitionName) { | ||
| super(tableBucket, partitionName); | ||
| } | ||
|
|
||
| @Override | ||
| public String splitId() { | ||
| return toSplitId(KV_BATCH_SPLIT_PREFIX, tableBucket); | ||
| } | ||
|
|
||
| @Override | ||
| protected byte splitKind() { | ||
| return KV_BATCH_SPLIT_FLAG; | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| return "KvBatchSplit{" | ||
| + "tableBucket=" | ||
| + tableBucket | ||
| + ", partitionName='" | ||
| + partitionName | ||
| + '\'' | ||
| + '}'; | ||
| } | ||
| } |
31 changes: 31 additions & 0 deletions
31
...uss-flink-common/src/main/java/org/apache/fluss/flink/source/split/KvBatchSplitState.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.fluss.flink.source.split; | ||
|
|
||
| /** State of {@link KvBatchSplit}. Has no resumable position. */ | ||
| public class KvBatchSplitState extends SourceSplitState { | ||
|
|
||
| public KvBatchSplitState(KvBatchSplit split) { | ||
| super(split); | ||
| } | ||
|
|
||
| @Override | ||
| public KvBatchSplit toSourceSplit() { | ||
| return (KvBatchSplit) split; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.