[server] fix stop-replica deletion stuck when TabletServer is offline#3369
Closed
gyang94 wants to merge 1 commit into
Closed
[server] fix stop-replica deletion stuck when TabletServer is offline#3369gyang94 wants to merge 1 commit into
gyang94 wants to merge 1 commit into
Conversation
gyang94
force-pushed
the
fix-stop-replicas-failed
branch
3 times, most recently
from
496b0d8 to
9e76737
Compare
gyang94
force-pushed
the
fix-stop-replicas-failed
branch
from
9e76737 to
5fac1ab
Compare
gyang94
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #3357
Brief change log
Previously, when a stopReplica(delete=true) RPC failed (e.g., TabletServer offline or network error), replicas got permanently stuck in ReplicaDeletionStarted, blocking table/partition deletion forever.
This PR aligns the deletion flow with Kafka's approach by introducing a
ReplicaDeletionIneligiblestate. When a stopReplica RPC fails to send or the target TabletServer goes offline, affected replicas are transitioned to ReplicaDeletionIneligible and the owning table/partition is marked ineligible for deletion. When the TabletServer reconnects, the ineligible mark is cleared and deletion is automatically retried.Tests
API and Format
Documentation