Skip to content

FINERACT-2302: Migrate collateral product to CommandDispatcher#5856

Merged
vidakovic merged 1 commit into
apache:developfrom
avivijay19:FINERACT-2302
May 20, 2026
Merged

FINERACT-2302: Migrate collateral product to CommandDispatcher#5856
vidakovic merged 1 commit into
apache:developfrom
avivijay19:FINERACT-2302

Conversation

@avivijay19
Copy link
Copy Markdown
Contributor

Migrates collateral product create/update/delete from the old CommandWrapper/PortfolioCommandSourceWritePlatformService pattern to the typed CommandDispatcher pipeline.

  • Add CollateralProductCreate/Update/Delete commands, request/response DTOs, and @component CommandHandler implementations (Resilience4j retry on each)
  • Switch CollateralManagementApiResource to dispatcher.dispatch(...) for create/update/delete
  • Remove old Create/Update/DeleteCollateralProductHandler and CollateralManagementWritePlatformServiceImpl
  • Rename CollateralManagementReadPlatformService/Impl → CollateralManagementReadService/Impl; add new CollateralManagementWriteService/Impl
  • Drop the now-unused CollateralManagementApiResourceSwagger (schemas live on the DTOs)
  • SecurityConfig: matchers for /collateral-management/*
  • application.properties: resilience4j retry instances for commandCollateralProductCreate/Update/Delete
  • Clean up CommandWrapperConstants / CommandWrapperBuilder entries

Jira: https://issues.apache.org/jira/browse/FINERACT-2302

@vidakovic vidakovic self-requested a review May 18, 2026 13:16
@avivijay19 avivijay19 force-pushed the FINERACT-2302 branch 4 times, most recently from 87e73f8 to 9b00b40 Compare May 20, 2026 10:33
Copy link
Copy Markdown
Contributor

@vidakovic vidakovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vidakovic vidakovic merged commit 3df3d9d into apache:develop May 20, 2026
103 of 106 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants