FINERACT-2302: Migrate collateral product to CommandDispatcher#5856
Open
avivijay19 wants to merge 1 commit into
Open
FINERACT-2302: Migrate collateral product to CommandDispatcher#5856avivijay19 wants to merge 1 commit into
avivijay19 wants to merge 1 commit into
Conversation
vidakovic
reviewed
May 18, 2026
vidakovic
reviewed
May 18, 2026
vidakovic
reviewed
May 18, 2026
vidakovic
reviewed
May 18, 2026
vidakovic
reviewed
May 18, 2026
| final CommandWrapper commandWrapper = new CommandWrapperBuilder().createCollateral() | ||
| .withJson(apiJsonSerializerService.serialize(collateralManagementProductRequest)).build(); | ||
| return this.commandsSourceWritePlatformService.logCommandSource(commandWrapper); | ||
| @ApiResponse(responseCode = "200", description = "OK", content = @Content(schema = @Schema(implementation = CollateralProductCreateResponse.class))) |
Contributor
There was a problem hiding this comment.
Not needed, you missed this one.
vidakovic
reviewed
May 18, 2026
| BigDecimal pctToBase = jsonCommand.bigDecimalValueOfParameterNamedDefaultToNullIfZero("pctToBase"); | ||
| String unitType = jsonCommand.stringValueOfParameterNamed("unitType"); | ||
| String name = jsonCommand.stringValueOfParameterNamed("name"); | ||
| public static CollateralManagementDomain createNew(final String name, final String quality, final BigDecimal basePrice, |
Contributor
There was a problem hiding this comment.
No, use Lombok builder please... these "replacements" for constructors have no added value and just create boilerplate code.
vidakovic
reviewed
May 18, 2026
| } | ||
|
|
||
| public Map<String, Object> update(final JsonCommand command, final ApplicationCurrency applicationCurrency) { | ||
| public Map<String, Object> update(final String name, final String quality, final String unitType, final BigDecimal basePrice, |
Contributor
There was a problem hiding this comment.
I am pretty sure this function is called only in one place. We should not add it to the entity, but move it to the service function where this is called. Then we can leave the entity class simple and not overload it with business logic. Note: I'm also convinced that the "changes" attributes (same in other packages) are rarely if at all used; but ok, let's leave them to avoid surprises. Anyway, stuff like this should be in the business logic service.
vidakovic
reviewed
May 18, 2026
| @RequestBody(required = true, content = @Content(schema = @Schema(implementation = CollateralProductRequest.class))) | ||
| @ApiResponse(responseCode = "200", description = "OK", content = @Content(schema = @Schema(implementation = CollateralManagementApiResourceSwagger.PutCollateralProductResponse.class))) | ||
| public CommandProcessingResult updateCollateral( | ||
| @ApiResponse(responseCode = "200", description = "OK", content = @Content(schema = @Schema(implementation = CollateralProductUpdateResponse.class))) |
Contributor
There was a problem hiding this comment.
You misse this. Not needed, we have types now. Remove the swagger @apiresponse annotation please. See earlier comment. Please make sure that you didn't miss any of these.
vidakovic
reviewed
May 18, 2026
| @Operation(summary = "Delete a Collateral", description = "Delete Collateral") | ||
| @ApiResponse(responseCode = "200", description = "OK", content = @Content(schema = @Schema(implementation = CollateralManagementApiResourceSwagger.DeleteCollateralProductResponse.class))) | ||
| public CommandProcessingResult deleteCollateral( | ||
| @ApiResponse(responseCode = "200", description = "OK", content = @Content(schema = @Schema(implementation = CollateralProductDeleteResponse.class))) |
vidakovic
reviewed
May 18, 2026
| private static final long serialVersionUID = 1L; | ||
|
|
||
| @Size(max = 200, message = "{org.apache.fineract.infrastructure.template.name.size}") | ||
| private String name; |
Contributor
There was a problem hiding this comment.
No Jakarta Validation annotations?
vidakovic
reviewed
May 18, 2026
|
|
||
| private Integer id; | ||
| @Hidden | ||
| private Long collateralId; |
Contributor
There was a problem hiding this comment.
No Jakarta Validation? Why is this one hidden? Please check the other request classes for validation annotations!
vidakovic
reviewed
May 18, 2026
| return CollateralProductDeleteResponse.builder().resourceId(request.getCollateralId()).build(); | ||
| } | ||
|
|
||
| private void validateForCreation(final CollateralProductCreateRequest request) { |
Contributor
There was a problem hiding this comment.
This can be done with Jakarta Validation annotations!
vidakovic
reviewed
May 18, 2026
| } | ||
| } | ||
|
|
||
| private void validateForDeletion(final CollateralManagementDomain collateralManagementDomain, final Long collateralId) { |
Contributor
There was a problem hiding this comment.
Try Jakarta Validation if possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates collateral product create/update/delete from the old CommandWrapper/PortfolioCommandSourceWritePlatformService pattern to the typed CommandDispatcher pipeline.
Jira: https://issues.apache.org/jira/browse/FINERACT-2302