FINERACT-2607: Use correct enum for processing results in audits#5852
FINERACT-2607: Use correct enum for processing results in audits#5852Hysnijee wants to merge 4 commits into
Conversation
|
@Hysnijee please sign your commit and write a test for this |
b42b88c to
18801da
Compare
18801da to
480285f
Compare
|
@Hysnijee @Kengne-yvana Has this discussed in Dev List Before? |
I am a new contributor, this is my first time. But I didn't see this being mentioned anywhere on Jira besides the issue that I created |
Fair point, I recommend you to subscribe to the fineract dev list, From what i am seeing you are changing schema values. When you are doing changes in existing based on functionality related changed. These needs to be discussed first. |
Thank you! I created a discussion in https://lists.apache.org/thread/fdm8c4ko68xvf593r0ofsrj2ks3tpvkf |
I just noticed that the values were already stored under a different name "processing_result_enum" so this migration is not needed, but we just need to fix the enum name. Adapted the PR. |
4d9cb0b to
3df92e5
Compare
…but on a different name
3df92e5 to
cebdb21
Compare
Description
These values were never persisted on new migration files; they existed on old migrations.
Additionally I also return the
enum_valueinstead ofenum_message_propertysince it's more readable and it will look better on the UI.Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.