Skip to content

FINERACT-2607: Use correct enum for processing results in audits#5852

Open
Hysnijee wants to merge 4 commits into
apache:developfrom
Hysnijee:FINERACT-2607-add-status-enum-values
Open

FINERACT-2607: Use correct enum for processing results in audits#5852
Hysnijee wants to merge 4 commits into
apache:developfrom
Hysnijee:FINERACT-2607-add-status-enum-values

Conversation

@Hysnijee
Copy link
Copy Markdown

Description

These values were never persisted on new migration files; they existed on old migrations.
Additionally I also return the enum_value instead of enum_message_property since it's more readable and it will look better on the UI.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@Kengne-yvana
Copy link
Copy Markdown
Contributor

@Hysnijee please sign your commit and write a test for this

@Hysnijee Hysnijee force-pushed the FINERACT-2607-add-status-enum-values branch from b42b88c to 18801da Compare May 15, 2026 10:03
@Hysnijee Hysnijee force-pushed the FINERACT-2607-add-status-enum-values branch from 18801da to 480285f Compare May 15, 2026 10:06
@Hysnijee
Copy link
Copy Markdown
Author

@Hysnijee please sign your commit and write a test for this

Verified the commits and adapted the integrationt test to assert this change on 480285f

@Aman-Mittal
Copy link
Copy Markdown
Member

@Hysnijee @Kengne-yvana Has this discussed in Dev List Before?

@Hysnijee
Copy link
Copy Markdown
Author

@Hysnijee @Kengne-yvana Has this discussed in Dev List Before?

I am a new contributor, this is my first time. But I didn't see this being mentioned anywhere on Jira besides the issue that I created

@Aman-Mittal
Copy link
Copy Markdown
Member

@Hysnijee @Kengne-yvana Has this discussed in Dev List Before?

I am a new contributor, this is my first time. But I didn't see this being mentioned anywhere on Jira besides the issue that I created

Fair point, I recommend you to subscribe to the fineract dev list, From what i am seeing you are changing schema values. When you are doing changes in existing based on functionality related changed. These needs to be discussed first.

@Hysnijee
Copy link
Copy Markdown
Author

@Hysnijee @Kengne-yvana Has this discussed in Dev List Before?

I am a new contributor, this is my first time. But I didn't see this being mentioned anywhere on Jira besides the issue that I created

Fair point, I recommend you to subscribe to the fineract dev list, From what i am seeing you are changing schema values. When you are doing changes in existing based on functionality related changed. These needs to be discussed first.

Thank you! I created a discussion in https://lists.apache.org/thread/fdm8c4ko68xvf593r0ofsrj2ks3tpvkf

@Hysnijee
Copy link
Copy Markdown
Author

Hysnijee commented May 18, 2026

@Hysnijee @Kengne-yvana Has this discussed in Dev List Before?

I am a new contributor, this is my first time. But I didn't see this being mentioned anywhere on Jira besides the issue that I created

Fair point, I recommend you to subscribe to the fineract dev list, From what i am seeing you are changing schema values. When you are doing changes in existing based on functionality related changed. These needs to be discussed first.

I just noticed that the values were already stored under a different name "processing_result_enum" so this migration is not needed, but we just need to fix the enum name. Adapted the PR.
This migration and discussion is not relevant anymore. But there are two missing values which so I added a migration for those two.

@Hysnijee Hysnijee changed the title FINERACT-2607: Add missing 'status' enum values for command processin… FINERACT-2607: Use correct enum for processing results in audits May 18, 2026
@Hysnijee Hysnijee force-pushed the FINERACT-2607-add-status-enum-values branch from 4d9cb0b to 3df92e5 Compare May 18, 2026 08:51
@Hysnijee Hysnijee force-pushed the FINERACT-2607-add-status-enum-values branch from 3df92e5 to cebdb21 Compare May 18, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants