FINERACT-2455: Add WC near-breach evaluation business step#5849
FINERACT-2455: Add WC near-breach evaluation business step#5849oleksii-novikov-onix wants to merge 2 commits into
Conversation
galovics
left a comment
There was a problem hiding this comment.
I'm not convinced CREDIT_BALANCE_REFUND should be in REDUCING_TRANSACTION_TYPES here.
A CREDIT_BALANCE_REFUND is the bank returning an overpayment to the borrower - money leaving the loan, not an inbound payment. Summing it in paidInWindow would make the borrower appear to have paid more than they actually did, and could suppress a near-breach trigger that should have fired. None of the e2e scenarios exercise this path, so a bug here would go undetected.
Wouldn't it make more sense to only count REPAYMENT and GOODWILL_CREDIT? (And worth a double-check on GOODWILL_CREDIT too - that's a bank-side write-off, not a borrower payment, though at least it goes the right direction.)
a743639 to
9ca4f57
Compare
|
@galovics Thanks, I removed CREDIT_BALANCE_REFUND |
9ca4f57 to
55cc88c
Compare
55cc88c to
ff9bfb2
Compare
Description
Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.