[fix](regression) fix stale expected output for one_level_nestedtypes_with_s3data#62488
Open
Mryange wants to merge 1 commit intoapache:masterfrom
Open
[fix](regression) fix stale expected output for one_level_nestedtypes_with_s3data#62488Mryange wants to merge 1 commit intoapache:masterfrom
Mryange wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Possible file(s) that should be tracked in LFS detected: 🚨The following file(s) exceeds the file size limit:
Consider using |
Contributor
Author
|
run buildall |
Contributor
Author
|
/review |
Contributor
There was a problem hiding this comment.
No blocking issues found.
Critical checkpoints:
- Goal of the task: Refresh the stale golden file for
regression-test/suites/datatype_p0/nested_types/base_cases/one_level_nestedtypes_with_s3data.groovyafter earlier engine-side behavior changes. The PR does that by updating the consumed expected-output fileregression-test/data/datatype_p0/nested_types/base_cases/one_level_nestedtypes_with_s3data.out. - Is the change small, clear, and focused: Yes. The PR only updates the generated regression result file for the affected suite.
- Concurrency: Not applicable. No concurrent code path or locking change is involved.
- Lifecycle management: Not applicable. No lifecycle-sensitive objects, static initialization, or ownership changes are involved.
- Configuration: None added or changed.
- Compatibility: No FE/BE protocol, storage format, or rolling-upgrade compatibility surface is changed.
- Parallel code paths: The relevant regression suite already covers the affected S3 nested-type read path; no missing sister-path code change is visible in this PR because this PR is only updating expected results.
- Special conditional checks: Not applicable.
- Test coverage: The existing regression suite already exercises this path. No new suite logic was needed for an expected-result refresh.
- Test result modification: Yes. The updated
.outfile is the artifact consumed by the regression framework for this suite. I did not find formatting or framework-path issues in the checked-in result file layout. - Observability: Not applicable for an expected-output refresh.
- Transaction and persistence: Not applicable.
- Data writes and modifications: Not applicable beyond regression golden data.
- FE/BE variable passing: None.
- Performance: Not applicable for this PR.
- Other issues: No blocking issue found in the submitted change itself.
Residual risk:
- I did not independently rerun the S3-backed regression in this runner, so correctness is inferred from the existing suite wiring and the PR rationale rather than reproduced end to end in this review session.,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: N/A
Problem Summary:
The regression test
datatype_p0/nested_types/base_cases/one_level_nestedtypes_with_s3datawas failing with aCHAR result mismatchon theorder_qt_sql_s3tag.Root-cause analysis:
one_level_array.parquet,.orc,.csv) inoss://doris-regression-hk/regression/datalake/have not changed since 2024-07-27 (confirmed viaossutil stat). The parquetc_boolcolumn islist<bool>(verified with pyarrow). The column type (array<boolean>) in the test plugin has also never changed.074d88b(PR [fix](nested-type) fix cases from s3 #55896, "fix cases from s3") addedWHERE k1 IS NOT NULLto the query and regenerated the.out. At that time, Doris had a bug in reading parquetlist<bool>values inside nested arrays, producing incorrect boolean values (e.g.[0, 0, 1, 0, ...]instead of the correct[0, 0, 0, 1, 1, ...]).0031179b1e6(PR [fix](parquet)fix parquet topn lazy mat complex data error result #58785, "fix parquet topn lazy mat complex data error result") refactoredColumnChunkReaderto useIN_COLLECTION/OFFSET_INDEXtemplate parameters, giving nested-array columns a distinct and correct read path. This fix incidentally corrected the boolean array reading for columns likec_bool.list<bool>correctly (matching pyarrow), but the.outfile was never updated, causing the test to fail.Fix: force-regenerate
one_level_nestedtypes_with_s3data.outusing the current correct Doris behavior against the unchanged S3 data.Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)