Skip to content

[refactor](fe) Extract isDynamicScheduleTable method to reduce code duplication #62477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zclllyybb merged 1 commit into from
Apr 15, 2026
+11 −3
Merged

[refactor](fe) Extract isDynamicScheduleTable method to reduce code duplication #62477

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions fe/fe-core/src/main/java/org/apache/doris/clone/DynamicPartitionScheduler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -972,6 +972,16 @@ private void clearDropPartitionFailedMsg(long tableId) {
createOrUpdateRuntimeInfo(tableId, DROP_PARTITION_MSG, DEFAULT_RUNTIME_VALUE);
}

/**
* DynamicPartitionScheduler keeps two kinds of tables in {@code dynamicPartitionTableInfo}: dynamic partition
* tables with scheduling enabled, and auto partition tables that rely on {@code partition.retention_count} for
* periodic cleanup.
*/
private boolean isDynamicScheduleTable(Table table) {
return table instanceof OlapTable && (((OlapTable) table).getPartitionRetentionCount() > 0
|| DynamicPartitionUtil.isDynamicPartitionTable(table));
}

private void initDynamicPartitionTable() {
for (Long dbId : Env.getCurrentEnv().getInternalCatalog().getDbIds()) {
Database db = Env.getCurrentInternalCatalog().getDbNullable(dbId);
Expand All @@ -982,9 +992,7 @@ private void initDynamicPartitionTable() {
for (Table table : tableList) {
table.readLock();
try {
if (table instanceof OlapTable
&& (((OlapTable) table).getPartitionRetentionCount() > 0
|| DynamicPartitionUtil.isDynamicPartitionTable(table))) {
if (isDynamicScheduleTable(table)) {
registerDynamicPartitionTable(db.getId(), table.getId());
}
} finally {
Expand Down
Loading