[fix](docker) dcr fe stop grace#62466
Merged
hello-stephen merged 2 commits intoapache:masterfrom Apr 15, 2026
Merged
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
JNSimba
approved these changes
Apr 14, 2026
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
CalvinKirs
approved these changes
Apr 14, 2026
Contributor
|
skip buildall |
Contributor
|
/review |
Contributor
There was a problem hiding this comment.
No blocking issues found in this PR.
Critical checkpoint conclusions:
- Goal of the task: The change makes the standard FE Kubernetes
preStophook use graceful shutdown, matching the existingfe_disaggregated_prestop.shand BEpreStopbehavior. The code accomplishes that goal. No automated test is included in the PR, so this remains validated by code-path consistency rather than an executed test. - Scope and clarity: The modification is minimal, clear, and focused to a single call site in
docker/runtime/fe/resource/fe_prestop.sh. - Concurrency: Not applicable. This is a shell shutdown hook with no shared in-process concurrency logic.
- Lifecycle management: No special lifecycle or static initialization concerns apply here.
- Configuration changes: None.
- Compatibility: No incompatible API, storage, or protocol change is introduced.
stop_fe.shalready supports--grace. - Parallel code paths: Applicable and handled well. This change brings the standard FE
preStoppath in line with the already-graceful disaggregated FE and BEpreStopscripts. - Special conditional checks: None added.
- Test coverage: No dedicated regression/unit test was added. For this shell-script change that is understandable, but manual validation in a containerized shutdown path would still be useful.
- Observability: Existing logging in
fe_prestop.shremains sufficient for this small change. - Transaction/persistence/data-write impact: None directly.
- Performance: No concern.
- Other issues: None identified from the modified code path.
Overall opinion: the patch is small, consistent with adjacent shutdown scripts, and looks correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)