Skip to content

test(sqllogictest): stabilize parquet output_rows_skew with WITH ORDER #21898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 3 commits into from
Apr 30, 2026
+8 −1
Merged

test(sqllogictest): stabilize parquet output_rows_skew with WITH ORDER #21898

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
85a706f
test(sqllogictest): stabilize parquet output_rows_skew with WITH ORDER
RatulDawar Apr 28, 2026
211d95f
Update datafusion/sqllogictest/test_files/explain_analyze.slt
RatulDawar Apr 29, 2026
760754d
Merge branch 'main' into fix/explain-analyze-parquet-skew-with-order
rluvaton Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion datafusion/sqllogictest/test_files/explain_analyze.slt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ EXPLAIN ANALYZE SELECT * FROM generate_series(100);
Plan with Metrics LazyMemoryExec: partitions=1, batch_generators=[generate_series: start=0, end=100, batch_size=8192], metrics=[output_rows=101, elapsed_compute=<slt:ignore>, output_bytes=<slt:ignore>]

# --------------------------------------------
# Test parquet-only output_rows_skew metric
# Test parquet-only output_rows_skew metric (WITH ORDER(x) → preserve_order scan)
# --------------------------------------------

statement ok
Comment thread
RatulDawar marked this conversation as resolved.
Expand All @@ -48,6 +48,7 @@ STORED AS PARQUET;
statement ok
CREATE EXTERNAL TABLE skew_parquet
STORED AS PARQUET
WITH ORDER (x)
LOCATION 'test_files/scratch/explain_analyze/output_rows_skew';

# All partition's output_rows: [4]
Expand All @@ -70,6 +71,7 @@ STORED AS PARQUET;
statement ok
CREATE EXTERNAL TABLE skew_parquet
STORED AS PARQUET
WITH ORDER (x)
LOCATION 'test_files/scratch/explain_analyze/output_rows_skew';

query TT
Expand Down Expand Up @@ -98,6 +100,7 @@ STORED AS PARQUET;
statement ok
CREATE EXTERNAL TABLE skew_parquet
STORED AS PARQUET
WITH ORDER (x)
LOCATION 'test_files/scratch/explain_analyze/output_rows_skew';

query TT
Expand All @@ -109,6 +112,7 @@ Plan with Metrics DataSourceExec: <slt:ignore>output_rows_skew=84.31%<slt:ignore
statement ok
CREATE EXTERNAL TABLE skew_parquet_single
STORED AS PARQUET
WITH ORDER (x)
LOCATION 'test_files/scratch/explain_analyze/output_rows_skew/f4.parquet';

query TT
Expand Down
Loading