fix: Skip flaky test in explain_analyze.slt#21866
Conversation
2010YOUY01
changed the title
explain_analyze.sltexplain_analyze.slt
2010YOUY01
force-pushed
the
fix-flaky-slt
branch
from
ce8c737 to
5076912
Compare
|
@2010YOUY01 I faced this issue in one of my pr and pushed the changed there can you check the approach 94d8f7d (it does require some comments though) |
I think the goal is to add this test case back once it becomes feasible. Since the surrounding tests already cover the base case, marking this one with |
Fair, I will remove the changes from my pr and wait for this one to get merged. |
|
Shall we file a ticket to track rewriting the test to be deterministic? If we are just going to ignore it indefinitely we should probably just remove it entirely 🤔 |
|
I mistakenly pushed to a wrong branch in this PR... 🤦🏼 I will delete this branch, and continue the work in #21898, I think it's possible to fix the test without disabling it now. |
apache#21898) ## Summary Adds `WITH ORDER (x)` to `CREATE EXTERNAL TABLE skew_parquet` / `skew_parquet_single` in `explain_analyze.slt` so `FileScanConfig` preserves scan ordering (`preserve_order`), keeping per-partition `output_rows` stable under dynamic file scheduling (PR apache#21351). ## Related - Follow-up to flaky skew assertions discussed around apache#21866 / apache#21850. ## Testing - `cargo test -p datafusion-sqllogictest --test sqllogictests -- explain_analyze` (recommended before merge) Sqllogictest-only change. Made with [Cursor](https://cursor.com) --------- Co-authored-by: Yongting You <2010youy01@gmail.com> Co-authored-by: Raz Luvaton <16746759+rluvaton@users.noreply.github.com>
3 participants
Which issue does this PR close?
explain_analyze.slt#21850Rationale for this change
The failing test can't be easily tested now, see the comment for the reason. So I suggest we suppress it now.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?