Skip to content

kill linux-build-lib from extended tests#21227

Merged
blaginin merged 3 commits intomainfrom
db/no-extended
May 6, 2026
Merged

kill linux-build-lib from extended tests#21227
blaginin merged 3 commits intomainfrom
db/no-extended

Conversation

@blaginin
Copy link
Copy Markdown
Member

I don't think we need that anymore:

  • the other extended tests are fast
  • it makes some tests to wait for the check (4 mins bottleneck for the CI time)
  • we have this base test in the main CI

@blaginin blaginin self-assigned this Mar 29, 2026
@github-actions github-actions Bot added the development-process Related to development process of DataFusion label Mar 29, 2026
@blaginin blaginin requested a review from 2010YOUY01 April 2, 2026 10:00
# Conflicts:
#	.github/workflows/extended.yml
Copy link
Copy Markdown
Contributor

@kosiew kosiew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blaginin
Thanks for the cleanup here. Approving with one small follow-up suggestion.

After this lands, it would be good to watch the first green run and confirm we get the CI latency improvement we want, and also make sure the removed pre-check job was not masking any early compile failures.

curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y
source $HOME/.cargo/env
rustup toolchain install
- name: Install Protobuf Compiler
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing linux-build-lib seems like a good tradeoff to help unblock the long-running extended suite sooner.

Since the deleted job was still carrying the same ad hoc Rust/protobuf bootstrap that linux-test-extended keeps below, could we do a follow-up and move that setup into ./.github/actions/setup-builder or another shared helper?

I think that would make future CI environment changes a little easier to manage in one place.

@alamb
Copy link
Copy Markdown
Contributor

alamb commented May 3, 2026

Do we still want to merge this PR? It has been hanging out for a while

@blaginin
Copy link
Copy Markdown
Member Author

blaginin commented May 3, 2026

We do! Missed the approval, thanks!

@alamb
Copy link
Copy Markdown
Contributor

alamb commented May 3, 2026

(I think it needs a merge up fro main to resolve conflicts and get all CI checks)

# Conflicts:
#	.github/workflows/extended.yml
@blaginin blaginin added this pull request to the merge queue May 6, 2026
Merged via the queue into main with commit 574326c May 6, 2026
65 checks passed
@blaginin blaginin deleted the db/no-extended branch May 6, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development-process Related to development process of DataFusion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants