Skip to content

perf(scheduler): stop re-encoding the session config for every task #2358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NoahKusaba wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

perf(scheduler): stop re-encoding the session config for every task #2358

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ballista/scheduler/src/state/task_manager.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -877,6 +877,7 @@ impl<T: 'static + AsLogicalPlan, U: 'static + AsExecutionPlan> TaskManager<T, U>
.as_millis() as u64;
let codec = self.codec.physical_extension_codec();

let props = first_task.session_config.to_key_value_pairs();
let mut multi_tasks = Vec::with_capacity(tasks.len());
for task in tasks {
let restricted = restrict_plan_to_partitions(
Expand All @@ -886,7 +887,6 @@ impl<T: 'static + AsLogicalPlan, U: 'static + AsExecutionPlan> TaskManager<T, U>
let mut plan_buf: Vec<u8> = vec![];
let plan_proto = PhysicalPlanNode::try_from_physical_plan(restricted, codec)?;
plan_proto.try_encode(&mut plan_buf)?;
let props = task.session_config.to_key_value_pairs();
let task_ids = vec![TaskId {
task_id: task.key.task_id as u32,
task_attempt_num: task.task_attempt as u32,
Expand All @@ -907,7 +907,7 @@ impl<T: 'static + AsLogicalPlan, U: 'static + AsExecutionPlan> TaskManager<T, U>
plan: plan_buf,
session_id: session_id.clone(),
launch_time,
props,
props: props.clone(),
});
}
Ok(multi_tasks)
Expand Down