Skip to content

chore(core): remove unused diagram module - #2355

Open
NoahKusaba wants to merge 1 commit into
apache:mainfrom
NoahKusaba:cleanup/remove-unused-diagram-module
Open

chore(core): remove unused diagram module#2355
NoahKusaba wants to merge 1 commit into
apache:mainfrom
NoahKusaba:cleanup/remove-unused-diagram-module

Conversation

@NoahKusaba

Copy link
Copy Markdown

Which issue does this PR close?

Closes #.

Rationale for this change

ballista_core::diagram has no callers anywhere in the repository. It was superseded by
scheduler/src/state/execution_graph_dot.rs and the CLI's job DOT popup, but stayed
publicly exported and carried two #[allow(deprecated)] attributes to keep a deprecated
CoalesceBatchesExec import compiling.

What changes are included in this PR?

  • Deleted ballista/core/src/diagram.rs (145 lines).
  • Removed the pub mod diagram; declaration from ballista/core/src/lib.rs.

Are there any user-facing changes?

Yes. ballista_core::diagram is removed from the public API of ballista-core. It has no
in-tree users, but this is a breaking change for any downstream consumer — may warrant the
api change label.

@NoahKusaba
NoahKusaba marked this pull request as draft August 22, 2026 17:46
@NoahKusaba
NoahKusaba marked this pull request as ready for review August 22, 2026 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant