Skip to content

NAS backup: support incremental backups of RBD volumes - #14386

Draft
weizhouapache wants to merge 24 commits into
apache:mainfrom
weizhouapache:24-incremental-backup-rbd-volume-on-nas
Draft

weizhouapache wants to merge 24 commits into
apache:mainfrom
weizhouapache:24-incremental-backup-rbd-volume-on-nas

nasbackup.sh: bring back the quiesce fixes of #14305 dropped by the m…

413b187
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 27, 2026 in 1s

20.69% (+0.01%) compared to 82e5ede

View this Pull Request on Codecov

20.69% (+0.01%) compared to 82e5ede

Details

Codecov Report

❌ Patch coverage is 64.32749% with 183 lines in your changes missing coverage. Please review.
✅ Project coverage is 20.69%. Comparing base (82e5ede) to head (413b187).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...rg/apache/cloudstack/backup/NASBackupProvider.java 65.84% 52 Missing and 17 partials ⚠️
...ce/wrapper/LibvirtRestoreBackupCommandWrapper.java 69.15% 39 Missing and 23 partials ⚠️
...ource/wrapper/LibvirtTakeBackupCommandWrapper.java 10.52% 15 Missing and 2 partials ⚠️
.../cloudstack/backup/RemoveBackupAnchorsCommand.java 30.00% 14 Missing ⚠️
...apache/cloudstack/backup/RestoreBackupCommand.java 0.00% 12 Missing ⚠️
...ervisor/kvm/resource/LibvirtComputingResource.java 0.00% 4 Missing ⚠️
utils/src/main/java/com/cloud/utils/RbdUtils.java 89.28% 2 Missing and 1 partial ⚠️
...pper/LibvirtRemoveBackupAnchorsCommandWrapper.java 92.59% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #14386      +/-   ##
============================================
+ Coverage     20.68%   20.69%   +0.01%     
- Complexity    21724    21797      +73     
============================================
  Files          6489     6495       +6     
  Lines        590173   591166     +993     
  Branches      72362    72530     +168     
============================================
+ Hits         122060   122363     +303     
- Misses       454842   455500     +658     
- Partials      13271    13303      +32     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.