[CELEBORN-2327] Add active-slot weight to load-aware placement#3685
Open
sunchao wants to merge 2 commits into
Open
[CELEBORN-2327] Add active-slot weight to load-aware placement#3685sunchao wants to merge 2 commits into
sunchao wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new optional celeborn.master.slot.assign.loadAware.activeSlotsWeight config (default 0.0) so load-aware slot placement can also account for each disk's currently-reserved active slots when sorting candidate disks, helping reduce placement skew under overlapping shuffle-heavy workloads.
Changes:
- Define and thread the new
activeSlotsWeightconfig fromCelebornConfthroughMaster.scalaintoSlotsAllocator.offerSlotsLoadAware/placeDisksToGroups, where it is added to the existing flush/fetch-time sort key. - Document the new tuning knob in
docs/configuration/master.mdand updatedocs/developers/slotsallocation.mdto reflect the updated ordering formula. - Add a regression test in
SlotsAllocatorSuiteJthat verifies, withactiveSlotsWeight=1and flush/fetch weights 0, the lower-active-slot worker is preferred over an otherwise equivalent overloaded worker.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala | Adds MASTER_SLOT_ASSIGN_LOADAWARE_ACTIVE_SLOTS_WEIGHT config entry and accessor. |
| master/src/main/scala/org/apache/celeborn/service/deploy/master/Master.scala | Reads new config and passes it into offerSlotsLoadAware. |
| master/src/main/java/org/apache/celeborn/service/deploy/master/SlotsAllocator.java | Adds activeSlotsWeight parameter and incorporates activeSlots * activeSlotsWeight into disk comparator. |
| master/src/test/java/org/apache/celeborn/service/deploy/master/SlotsAllocatorSuiteJ.java | Adds regression test and threads new parameter through existing helper call sites. |
| docs/configuration/master.md | Documents new config row. |
| docs/developers/slotsallocation.md | Updates ordering formula description. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SteNicholas
approved these changes
May 14, 2026
Member
SteNicholas
left a comment
There was a problem hiding this comment.
LGTM. Thanks for contribution.
pan3793
reviewed
May 14, 2026
pan3793
reviewed
May 14, 2026
pan3793
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Celeborn load-aware slot placement currently orders candidate disks using flush and fetch timing only. That can still keep assigning new partitions onto disks that already carry a large amount of reserved active-slot pressure, which makes placement skew worse under overlapping shuffle-heavy workloads. CELEBORN-2327 tracks this gap.
What changes were proposed in this PR?
celeborn.master.slot.assign.loadAware.activeSlotsWeightconfig.activeSlots * activeSlotsWeightin load-aware disk ordering.How was this PR tested?
UPDATE=1 build/mvn clean test -pl common -am -Dtest=none -DwildcardSuites=org.apache.celeborn.ConfigurationSuite./build/mvn -pl master -am -Dtest=SlotsAllocatorSuiteJ -DwildcardSuites=org.apache.celeborn.NoSuchSuite -DfailIfNoTests=false test./build/mvn -pl master -am -DskipTests test-compile