Skip to content

[AURON #2171] Add sort suite wrappers for Spark versions#2275

Open
myandpr wants to merge 1 commit into
apache:masterfrom
myandpr:add-sort-suite-wrappers
Open

[AURON #2171] Add sort suite wrappers for Spark versions#2275
myandpr wants to merge 1 commit into
apache:masterfrom
myandpr:add-sort-suite-wrappers

Conversation

@myandpr
Copy link
Copy Markdown
Contributor

@myandpr myandpr commented May 16, 2026

Which issue does this PR close?

Closes #2171

Rationale for this change

Spark 3.3 already has sort operator correctness test wrappers. This PR extends the same sort correctness coverage to the other supported Spark test modules requested by the issue.

What changes are included in this PR?

  • Add sort operator correctness suite wrappers for:
    • Spark 3.1
    • Spark 3.2
    • Spark 3.4
    • Spark 3.5
    • Spark 4.0
    • Spark 4.1
  • Enable AuronDataFrameSuite in each corresponding AuronSparkTestSettings.
  • Keep the same DataFrame suite exclusions as the existing Spark 3.3 wrapper.

Are there any user-facing changes?

No. This PR only adds test coverage.

How was this patch tested?

  • Test compile for affected Spark 3.x and Spark 4.x test modules

@myandpr
Copy link
Copy Markdown
Contributor Author

myandpr commented May 16, 2026

Hi! @ShreyeshArangath @slfan1989, could you help review this PR when convenient?

It extends the existing Spark 3.3 sort correctness test wrappers to the other supported Spark versions requested in #2171.

Many thanks!

@myandpr myandpr force-pushed the add-sort-suite-wrappers branch from 25bf8d7 to 284b361 Compare May 16, 2026 18:51
@myandpr myandpr force-pushed the add-sort-suite-wrappers branch from 284b361 to 93e082e Compare May 17, 2026 05:04
@myandpr
Copy link
Copy Markdown
Contributor Author

myandpr commented May 17, 2026

quick note: conflict resolved.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends Auron’s Spark correctness-test coverage for sort-related DataFrame behaviors to all other supported Spark test modules by adding AuronDataFrameSuite wrappers (patterned after the existing Spark 3.3 setup) and enabling them in each module’s AuronSparkTestSettings.

Changes:

  • Added AuronDataFrameSuite for Spark 3.1, 3.2, 3.4, 3.5, 4.0, and 4.1 (with Spark-4.x-specific expression/Column construction where needed).
  • Enabled AuronDataFrameSuite in each corresponding AuronSparkTestSettings.
  • Applied the same exclusion list used by the existing Spark 3.3 wrapper to avoid known-incompatible upstream DataFrameSuite cases and replaced some with Auron-prefixed versions.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
auron-spark-tests/spark31/src/test/scala/org/apache/spark/sql/AuronDataFrameSuite.scala Adds Spark 3.1 wrapper suite for DataFrame sort/repartition correctness with Auron-prefixed test variants.
auron-spark-tests/spark31/src/test/scala/org/apache/auron/utils/AuronSparkTestSettings.scala Enables AuronDataFrameSuite and excludes known-incompatible upstream tests for Spark 3.1.
auron-spark-tests/spark32/src/test/scala/org/apache/spark/sql/AuronDataFrameSuite.scala Adds Spark 3.2 wrapper suite matching the established Spark 3.3 pattern.
auron-spark-tests/spark32/src/test/scala/org/apache/auron/utils/AuronSparkTestSettings.scala Enables AuronDataFrameSuite and applies the established exclusion list for Spark 3.2.
auron-spark-tests/spark34/src/test/scala/org/apache/spark/sql/AuronDataFrameSuite.scala Adds Spark 3.4 wrapper suite matching the established Spark 3.3 pattern.
auron-spark-tests/spark34/src/test/scala/org/apache/auron/utils/AuronSparkTestSettings.scala Enables AuronDataFrameSuite and applies the established exclusion list for Spark 3.4.
auron-spark-tests/spark35/src/test/scala/org/apache/spark/sql/AuronDataFrameSuite.scala Adds Spark 3.5 wrapper suite matching the established Spark 3.3 pattern.
auron-spark-tests/spark35/src/test/scala/org/apache/auron/utils/AuronSparkTestSettings.scala Enables AuronDataFrameSuite and applies the established exclusion list for Spark 3.5.
auron-spark-tests/spark40/src/test/scala/org/apache/spark/sql/AuronDataFrameSuite.scala Adds Spark 4.0 wrapper suite with Spark-4.x ExpressionColumnNode handling.
auron-spark-tests/spark40/src/test/scala/org/apache/auron/utils/AuronSparkTestSettings.scala Enables AuronDataFrameSuite and applies the established exclusion list for Spark 4.0.
auron-spark-tests/spark41/src/test/scala/org/apache/spark/sql/AuronDataFrameSuite.scala Adds Spark 4.1 wrapper suite with Spark-4.x ExpressionColumnNode handling.
auron-spark-tests/spark41/src/test/scala/org/apache/auron/utils/AuronSparkTestSettings.scala Enables AuronDataFrameSuite and applies the established exclusion list for Spark 4.1.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Correctness Testing] All Spark Versions - Add Sort operator related tests

4 participants