[AURON #2171] Add sort suite wrappers for Spark versions#2275
Conversation
|
Hi! @ShreyeshArangath @slfan1989, could you help review this PR when convenient? It extends the existing Spark 3.3 sort correctness test wrappers to the other supported Spark versions requested in #2171. Many thanks! |
25bf8d7 to
284b361
Compare
284b361 to
93e082e
Compare
|
quick note: conflict resolved. |
There was a problem hiding this comment.
Pull request overview
This PR extends Auron’s Spark correctness-test coverage for sort-related DataFrame behaviors to all other supported Spark test modules by adding AuronDataFrameSuite wrappers (patterned after the existing Spark 3.3 setup) and enabling them in each module’s AuronSparkTestSettings.
Changes:
- Added
AuronDataFrameSuitefor Spark 3.1, 3.2, 3.4, 3.5, 4.0, and 4.1 (with Spark-4.x-specific expression/Column construction where needed). - Enabled
AuronDataFrameSuitein each correspondingAuronSparkTestSettings. - Applied the same exclusion list used by the existing Spark 3.3 wrapper to avoid known-incompatible upstream
DataFrameSuitecases and replaced some with Auron-prefixed versions.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| auron-spark-tests/spark31/src/test/scala/org/apache/spark/sql/AuronDataFrameSuite.scala | Adds Spark 3.1 wrapper suite for DataFrame sort/repartition correctness with Auron-prefixed test variants. |
| auron-spark-tests/spark31/src/test/scala/org/apache/auron/utils/AuronSparkTestSettings.scala | Enables AuronDataFrameSuite and excludes known-incompatible upstream tests for Spark 3.1. |
| auron-spark-tests/spark32/src/test/scala/org/apache/spark/sql/AuronDataFrameSuite.scala | Adds Spark 3.2 wrapper suite matching the established Spark 3.3 pattern. |
| auron-spark-tests/spark32/src/test/scala/org/apache/auron/utils/AuronSparkTestSettings.scala | Enables AuronDataFrameSuite and applies the established exclusion list for Spark 3.2. |
| auron-spark-tests/spark34/src/test/scala/org/apache/spark/sql/AuronDataFrameSuite.scala | Adds Spark 3.4 wrapper suite matching the established Spark 3.3 pattern. |
| auron-spark-tests/spark34/src/test/scala/org/apache/auron/utils/AuronSparkTestSettings.scala | Enables AuronDataFrameSuite and applies the established exclusion list for Spark 3.4. |
| auron-spark-tests/spark35/src/test/scala/org/apache/spark/sql/AuronDataFrameSuite.scala | Adds Spark 3.5 wrapper suite matching the established Spark 3.3 pattern. |
| auron-spark-tests/spark35/src/test/scala/org/apache/auron/utils/AuronSparkTestSettings.scala | Enables AuronDataFrameSuite and applies the established exclusion list for Spark 3.5. |
| auron-spark-tests/spark40/src/test/scala/org/apache/spark/sql/AuronDataFrameSuite.scala | Adds Spark 4.0 wrapper suite with Spark-4.x ExpressionColumnNode handling. |
| auron-spark-tests/spark40/src/test/scala/org/apache/auron/utils/AuronSparkTestSettings.scala | Enables AuronDataFrameSuite and applies the established exclusion list for Spark 4.0. |
| auron-spark-tests/spark41/src/test/scala/org/apache/spark/sql/AuronDataFrameSuite.scala | Adds Spark 4.1 wrapper suite with Spark-4.x ExpressionColumnNode handling. |
| auron-spark-tests/spark41/src/test/scala/org/apache/auron/utils/AuronSparkTestSettings.scala | Enables AuronDataFrameSuite and applies the established exclusion list for Spark 4.1. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Which issue does this PR close?
Closes #2171
Rationale for this change
Spark 3.3 already has sort operator correctness test wrappers. This PR extends the same sort correctness coverage to the other supported Spark test modules requested by the issue.
What changes are included in this PR?
AuronDataFrameSuitein each correspondingAuronSparkTestSettings.Are there any user-facing changes?
No. This PR only adds test coverage.
How was this patch tested?