ARTEMIS-5534 use Objects.requireNonNullElse() where sensible#5771
Merged
tabish121 merged 1 commit intoapache:mainfrom Jun 16, 2025
Merged
ARTEMIS-5534 use Objects.requireNonNullElse() where sensible#5771tabish121 merged 1 commit intoapache:mainfrom
tabish121 merged 1 commit intoapache:mainfrom
Conversation
tabish121
reviewed
Jun 11, 2025
tabish121
reviewed
Jun 11, 2025
jbertram
force-pushed
the
ARTEMIS-5534
branch
7 times, most recently
from
b3c00a2 to
8e7e37e
Compare
tabish121
reviewed
Jun 16, 2025
| } | ||
| } | ||
| } catch (Exception e) { | ||
| e.printStackTrace(); |
Contributor
There was a problem hiding this comment.
This seems like it was added and then forgotten about ?
The code-base is littered with uses of Java's ternary operator to check for null and fallback to a default value. Many of these can be replaced with either `Objects.requireNonNullElse` or `Objects.requireNonNullElseGet`. The latter is used where appropriate to essentially match the short-circuit semantics provided by the ternary operator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code-base is littered with uses of Java's ternary operator to check for null and fallback to a default value. Many of these can be replaced with either
Objects.requireNonNullElseorObjects.requireNonNullElseGet. The latter is used where appropriate to essentially match the short-circuit semantics provided by the ternary operator.