GH-49743: [Release] Split the vote thread preparation into its own shell script#49770
GH-49743: [Release] Split the vote thread preparation into its own shell script#49770raulcd merged 2 commits intoapache:mainfrom
Conversation
raulcd
requested review from
amoeba and
kou
and removed request for
assignUser,
jonkeane and
kou
|
|
github-actions
Bot
added
Component: Documentation
awaiting committer review
|
Can I update the existing tests? |
oops, sorry I completely forgot about the tests :P, please yes do update them! |
| : ${SOURCE_DEFAULT:=1} | ||
| : ${SOURCE_CLEANUP:=${SOURCE_DEFAULT}} | ||
| : ${SOURCE_DOWNLOAD:=${SOURCE_DEFAULT}} | ||
| : ${SOURCE_VOTE:=${SOURCE_DEFAULT}} |
There was a problem hiding this comment.
Let's use VOTE_ (or VOTE_EMAIL_) as the prefix.
| echo "Downloading tarball and checksums for ${tag}" | ||
| # Wait for the release candidate workflow to finish before attempting | ||
| # to download the tarball from the GitHub Release. | ||
| . $SOURCE_DIR/utils-watch-gh-workflow.sh ${tag} "release_candidate.yml" | ||
| rm -rf artifacts | ||
| gh release download ${tag} \ | ||
| --dir artifacts \ | ||
| --repo "${GITHUB_REPOSITORY}" \ | ||
| --pattern "${tarball}.*" |
| # Wait for the release candidate workflow to finish before attempting | ||
| # to download the tarball from the GitHub Release. | ||
| . $SOURCE_DIR/utils-watch-gh-workflow.sh ${tag} "release_candidate.yml" |
There was a problem hiding this comment.
We don't need to wait for the workflow. This must be finished when we use this script.
github-actions
Bot
added
awaiting changes
|
I've pushed my suggestions. |
|
Thanks @kou for the improvements! |
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 8595105. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
2 participants
Rationale for this change
Currently running the script is failing if default flags are used and also failing if we run the source vote in separation as documented on the release.rst page.
What changes are included in this PR?
Splitting the script into two each one for it's own purpose will make it easier to focus and have less "flag" incompatibilities which to be fair is unnecessary for the purpose of these minor scripts.
Are these changes tested?
Yes, I've tested the new script in isolation to generate a new vote email.
Are there any user-facing changes?
No
SOURCE_UPLOADand defaultSOURCE_VOTEfails #49743