-
Notifications
You must be signed in to change notification settings - Fork 4.1k
GH-24868: [C++] Add a Tensor logical value type with varying dimensions, implemented using ExtensionType #37166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 17 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
b205109
Initial commit
rok e317bf4
Python wrapper
rok 1c46c2e
Add VariableShapeTensorArray::ToTensor(i)
rok 18c88a2
Add ragged_dimensions
rok 4d3eb44
Replace ragged_dimensions with uniform_dimensions
rok 5bc3266
Add example for explanation
rok 02c3108
Add uniform_shape parameter
rok 10d20a3
Apply suggestions from code review
rok d737130
Review feedback
rok e646a79
Update docs/source/format/CanonicalExtensions.rst
rok 0fafcca
Review feedback
rok 18984fe
Removing implementation
rok ff60349
Simplify uniform_dimensions/uniform_shape
rok 78c6bd4
Apply suggestions from code review
rok 90668e0
Update docs/source/format/CanonicalExtensions.rst
rok 09fd14f
Update docs/source/format/CanonicalExtensions.rst
rok 8b80ced
Review feedback
rok 2327085
Update docs/source/format/CanonicalExtensions.rst
jorisvandenbossche File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, one more small nitpick: the minimal metadata is actually no metadata, which is typically represented as an empty string (I am actually not fully sure if in this case the metadata key could also just not be present in the field metadata), instead of an empty json dict (I don't think we should necessarily recommend using an empty dict)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a fair point! Empty string feels like the safer choice here. See my suggested change below.