Skip to content

fix(tests): repair two install lines #1076 spliced mid-line - #1084

Merged
svc-template-updater merged 1 commit into
mainfrom
fix/tests-mangled-install-lines
Aug 20, 2026
Merged

fix(tests): repair two install lines #1076 spliced mid-line#1084
svc-template-updater merged 1 commit into
mainfrom
fix/tests-mangled-install-lines

Conversation

@svc-template-updater

Copy link
Copy Markdown
Contributor

#1076 inserted a dep install into 20 tests.sh. In two of them the insertion landed mid-line and split the original runner install in half, leaving papermill <package-spec> as a command of its own:

# asynchronous_inference
uv pip install --system --no-cache-dir uv pip install -r python_depset.lock ...
papermill "nbconvert==7.16.6" ipykernel
# workspace-intro
pip install -q uv pip install -q --system emoji
papermill nbconvert==7.16.6 ipykernel

Both are valid bash, which is why that PR's bash -n sweep came back clean. Neither installs papermill, and the orphaned line runs it with a version pin as its input notebook.

Impact

template-probe 146 — the first daily run after #1076 merged — failed on no such option: --system, the only red job of 38. asynchronous_inference isn't in the probe set, so its breakage was silent.

The check-depsets pre-commit hook passed on both: it greps for the lock path, so the mangled line still looked like an install.

Testing

/test-template asynchronous_inference workspace-intro.

#1076 inserted a dep install into 20 tests.sh; in two of them the insertion
landed mid-line and split the original runner install in half, leaving
`papermill <package-spec>` as a command of its own. Valid bash, which is why
that PR's `bash -n` sweep came back clean -- but papermill is never installed
and the orphaned line runs it against a version pin.

template-probe 146, the first daily run after #1076 merged, failed on
`no such option: --system` and was the only red job of 38.
asynchronous_inference is not probed, so its breakage was silent.

Signed-off-by: Aydin Abiar <aydin@anyscale.com>
@svc-template-updater

Copy link
Copy Markdown
Contributor Author

/test-template asynchronous_inference workspace-intro

@svc-template-updater
svc-template-updater merged commit c997d59 into main Aug 20, 2026
5 checks passed
@svc-template-updater
svc-template-updater deleted the fix/tests-mangled-install-lines branch August 20, 2026 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants