fix(tests): repair two install lines #1076 spliced mid-line - #1084
Merged
Conversation
#1076 inserted a dep install into 20 tests.sh; in two of them the insertion landed mid-line and split the original runner install in half, leaving `papermill <package-spec>` as a command of its own. Valid bash, which is why that PR's `bash -n` sweep came back clean -- but papermill is never installed and the orphaned line runs it against a version pin. template-probe 146, the first daily run after #1076 merged, failed on `no such option: --system` and was the only red job of 38. asynchronous_inference is not probed, so its breakage was silent. Signed-off-by: Aydin Abiar <aydin@anyscale.com>
Contributor
Author
|
/test-template asynchronous_inference workspace-intro |
Aydin-ab
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1076 inserted a dep install into 20
tests.sh. In two of them the insertion landed mid-line and split the original runner install in half, leavingpapermill <package-spec>as a command of its own:Both are valid bash, which is why that PR's
bash -nsweep came back clean. Neither installs papermill, and the orphaned line runs it with a version pin as its input notebook.Impact
template-probe146 — the first daily run after #1076 merged — failed onno such option: --system, the only red job of 38.asynchronous_inferenceisn't in the probe set, so its breakage was silent.The
check-depsetspre-commit hook passed on both: it greps for the lock path, so the mangled line still looked like an install.Testing
/test-template asynchronous_inference workspace-intro.