Skip to content

fix: redact GitHub token from git clone error messages in eval engine #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gn00295120 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: redact GitHub token from git clone error messages in eval engine #87

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a0daf5
fix: redact GitHub token from git clone error messages
gn00295120 Mar 23, 2026
b8046b7
fix: use errors='replace' in stderr decode to prevent UnicodeDecodeError
gn00295120 Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions claudecode/evals/eval_engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,12 +235,19 @@ def _setup_repository(self, test_case: EvalCase) -> Tuple[bool, str, str]:
clone_url = f"https://github.com/{repo_name}.git"
if self.github_token:
clone_url = f"https://{self.github_token}@github.com/{repo_name}.git"

try:
subprocess.run(['git', 'clone', '--filter=blob:none', clone_url, base_repo_path],
check=True, capture_output=True, timeout=TIMEOUT_CLONE)
except subprocess.CalledProcessError as e:
error_msg = f"Failed to clone repository: {e.stderr.decode()}"
stderr = e.stderr.decode(errors='replace') if e.stderr else ""
# Redact the GitHub token from git's error output.
# Git may echo the clone URL (which embeds the token)
# in stderr when the clone fails, leaking the credential
# into logs and the JSON result file on disk.
if self.github_token:
stderr = stderr.replace(self.github_token, "[REDACTED]")
error_msg = f"Failed to clone repository: {stderr}"
self.log(error_msg)
return False, "", error_msg

Expand Down