Repository navigation
queue toolbar clicks until the relay starts, and show it on the badge - #237
Merged
Merged
Conversation
thdxr
force-pushed
the
fix/toolbar-offline
branch
from
November 12, 2026 03:23
198acc8 to
b0b03d2
Compare
clicks wait in chrome.storage.session so a worker stop doesn't lose them, and the badge says "…" until the relay takes them. a second click cancels. a relay that refuses this browser or speaks another version drops the queue, because the next click opens the setup page instead.
thdxr
force-pushed
the
fix/toolbar-offline
branch
from
November 12, 2026 03:27
b0b03d2 to
4fcd135
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a toolbar click on a normal page while the relay wasn't running gave no feedback, and the clicked tab waited only in memory, so it was lost when the service worker stopped.
what changed:
tests: test/isolated/toolbar-queue.ts covers queueing with the badge and storage, the flush on connect, the restore across a worker restart with a closed tab dropped, the cancel by a second click, the drop on a protocol mismatch, a click landing while the queue is flushed, a queued tab closing, a close during the restore, and a click that wakes the worker before it finds the browser unpaired.
fixes #236
reported by @soultaster, who also suggested persisting the queue in session storage
— from 𝕺𝖕𝖊𝖓𝕮𝖔𝖉𝖊