Repository navigation
fix(mcp): emit single-type enums in settings tool schema - #232
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the settings tool advertised
idleMinutesas one enum mixing numbers and"never". some MCP clients/providers (Kimi CLI) reject mixed-type enums and fail the whole tool list.now each setting's schema is emitted as single-typed enums (an
anyOfof the integer enum[10, 30, 60]and the string enum["never"]); runtime decoding is unchanged.adds a test that every advertised input/output schema keeps each
enum/constto one JSON type.Fixes #231
Thanks to @adusingi for the diagnosis and suggested schema shape in #231.