feat(cxl-ui): add ability for main content to be scrolled from the ou…#15
feat(cxl-ui): add ability for main content to be scrolled from the ou…#15
Conversation
|
Another customer request https://app.intercom.com/a/apps/wpyu0avy/inbox/inbox/all/conversations/41839800227390 @anoblet any thoughts on whether there's a more optimal solution of some kind? |
|
@leho I don't have access to the document :) |
Intercom ticket isn't important, it just repeats the problem description of people not figuring out to scroll content pane. Maybe there's a simpler solution of some kind than forwarding scroll events.. a) animate / shake the screen if scrolled outside, or something. They need a signal to go scroll in content pane. |
|
Maybe some sort of notification similar to Google Maps where they remind the user to use I'll do some research :) |
|
I tried making CSS adjustments to see if we could accomplish what we needed, but ran into difficulties with the overlap of different layout structures. We may want to consider breaking out each layout type into separate components. https://www.loom.com/share/31d8a50fb48b4ce8a084ff1b384c688a I'll start testing the Google Maps feature now. |
|
Here's the notification/highlight version: |
size-limit report 📦
|
anoblet
force-pushed
the
external-scroll
branch
from
c9767ba to
4f623e4
Compare
|
We might be able to use this to normalize the scrolling: |
anoblet
force-pushed
the
external-scroll
branch
from
265b8cd to
8d85bc0
Compare
|
@leho I had to fork normalize-wheel and convert it to ESM because Pika wasn't building. It seems to work fairly well though. |
| "lit-element": "^2.2.1", | ||
| "lit-html": "^2.0.0-rc.3" | ||
| "lit-html": "^2.0.0-rc.3", | ||
| "normalize-wheel": "https://github.com/anoblet/normalize-wheel#esm" |
There was a problem hiding this comment.
If we have to fork this anyway, perhaps we can also drop some of the general compatibility check code from it? If not, that's fine, too, but worth a look.
There was a problem hiding this comment.
I'm not sure how much I can trim away without there being regressions in certain browsers but I can take a look.
There was a problem hiding this comment.
Is there a PR we can shoot at normalize-wheel upstream way?
I'm going to publish our current ESM build on our custom registry, but ideally we'd at one point get back to using global NPM for this.
There was a problem hiding this comment.
I tried to structure it as a PR in the first place. I was unsure what the best practice was for offering CJS/ESM in the same package unbundled. A separate directory under src and leverage the browser field in package.json?
I ended up just installing from a branch to save time. I'll see if I can figure out how to do this though.
There was a problem hiding this comment.
I created a PR here: basilfx/normalize-wheel#3
In the meantime I believe we could rely on this: https://www.npmjs.com/package/normalize-wheel-es
There was a problem hiding this comment.
Looks like they did the same thing, and never bothered to PR.
Let's see what happens in basilfx/normalize-wheel#3 before we make a decision.
Ideally that PR would be a bit less noisy, or code-unified.. but I'm not so well-versed to understand how to pull it off.
|
This was deployed live with conversionxl@8fd661f |
2 participants
…tside