animint.js: remove unnecessary Selectors.hasOwnProperty checks

[ANAMASGARD]

Fixes #278

• Replaced Selectors.hasOwnProperty(selector_name) with a simple selector_name check in draw_geom and geom_label_aligned.
• Removed redundant guard in update_selector.
• Removed Selectors.hasOwnProperty check in update_axes.

I confirm I have not used any AI code generation tools for this PR.

[codecov]

Codecov Report

❌ Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 73.03%. Comparing base (a4220df) to head (3e7b176).

Files with missing lines	Patch %	Lines
inst/htmljs/animint.js	88.88%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #306   +/-   ##
=======================================
  Coverage   73.02%   73.03%           
=======================================
  Files         164      164           
  Lines        8837     8840    +3     
=======================================
+ Hits         6453     6456    +3     
  Misses       2384     2384           

Flag	Coverage Δ
javascript	81.25% <88.88%> (+0.01%)	⬆️
r	69.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[tdhock]

also please investigate CI failure

[ANAMASGARD]

Sir @tdhock , if(selector_name) guards in Changes 1 and 2 cannot be removed safely — [selector_name] is null on initial geom rendering, so without the guards, Selectors[null].duration throws a TypeError and breaks all 149 JS tests.
The guards are not about checking hasOwnProperty on [Selectors]; they handle the case where no selector is active at all.
I removed them in previous commit which caused error , please give your feedback .

[tdhock]

please revise

[tdhock]

ok i see now " [selector_name] is null on initial geom rendering" why and when does that happen?
i thought none of these blocks should run (and we can do no rendering) if we don’t have json info? (including selectors)

[ANAMASGARD]

Sir @tdhock thanks for the review ,

• !! removed — the function is only ever called inside if(...), so JavaScript already handles truthy/falsy correctly there. No need to force a boolean.

• Selectors.hasOwnProperty(name) removed — agree with your point. If name is a real selector, it should already be in Selectors, so checking membership here is redundant.

• name && kept — this one is actually necessary. During initial rendering, draw_geom and geom_label_aligned run for every geom, including ones that have no selector at all. For those, selector_name is null. If I remove the name && guard, Selectors[null] throws a TypeError and crashes all JS tests. I confirmed this in an earlier commit where removing it caused all 149 JS tests to fail.