Skip to content

Test coord equal#253

Open
tdhock wants to merge 20 commits into
masterfrom
test-coord_equal
Open

Test coord equal#253
tdhock wants to merge 20 commits into
masterfrom
test-coord_equal

Conversation

@tdhock
Copy link
Copy Markdown
Collaborator

@tdhock tdhock commented Oct 15, 2025 •
edited
Loading

Closes #243

@tdhock tdhock mentioned this pull request Oct 15, 2025
Closed
@tdhock tdhock marked this pull request as draft October 15, 2025 15:46
@tdhock
Copy link
Copy Markdown
Collaborator Author

tdhock commented Oct 15, 2025 •
edited
Loading

No obvious timing issues in HEAD=test-coord_equal
Comparison Plot

Generated via commit 6277a93

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 2 minutes and 31 seconds
Installing different package versions 14 seconds
Running and plotting the test cases 2 minutes and 45 seconds

@ANAMASGARD ANAMASGARD marked this pull request as ready for review November 17, 2025 05:18
@tdhock
Copy link
Copy Markdown
Collaborator Author

tdhock commented Nov 27, 2025

please post updated screenshot and fix tests

@ANAMASGARD
Copy link
Copy Markdown
Contributor

ANAMASGARD commented Mar 11, 2026

Sir @tdhock updated screenshot , please review :-
Screenshot From 2026-03-11 11-43-59

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 11, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.05%. Comparing base (a4220df) to head (707738a).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #253      +/-   ##
==========================================
+ Coverage   73.02%   73.05%   +0.03%     
==========================================
  Files         164      164              
  Lines        8837     8847      +10     
==========================================
+ Hits         6453     6463      +10     
  Misses       2384     2384
Flag Coverage Δ
javascript 81.29% <100.00%> (+0.05%) ⬆️
r 69.14% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ANAMASGARD ANAMASGARD mentioned this pull request May 18, 2026
Open
ANAMASGARD and others added 5 commits May 18, 2026 09:35
@ANAMASGARD
Merge branch 'master' into test-coord_equal
929e42e
@ANAMASGARD
Merge branch 'master' into test-coord_equal
56a52eb
@ANAMASGARD
Merge branch 'master' into test-coord_equal
109e061
@ANAMASGARD
fix(ci): update atime Slow/Fast SHAs to installable commits
608ae1c 
The previous Slow baseline (352f7e) fails package install on R 4.6 in
atime CI due to geom_dotplot Rd build errors. Use master (a4220df)
and PR head as installable comparison commits.
@ANAMASGARD
fix(ci): restore atime #238 getCommonChunk baseline SHAs
bdcbf3f 
Replace mistaken Slow/Fast pins (master vs coord_equal PR) with
installable commits that bracket the real PR #238 getCommonChunk
optimization. Slow uses e32921c (pre-refactor, R 4.6 installable);
Fast uses 3095077 (last #238 commit). Unrelated to PR #253 coord_equal.
@ANAMASGARD ANAMASGARD mentioned this pull request May 29, 2026
Open
@ANAMASGARD
fix(ci): simplify atime #238 test config and stub old geom_dotplot Rd
707738a 
Document Slow/Fast SHAs for getCommonChunk (PR #238). Use pkg.edit.fun
so pre-#311 commits install on R 4.6 CI. Unrelated to coord_equal.
tdhock
tdhock commented May 29, 2026
View reviewed changes
Comment thread tests/testthat/test-renderer-coord_equal.R Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@suhaani-agarwal suhaani-agarwal Awaiting requested review from suhaani-agarwal

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tdhock @ANAMASGARD