Fix consensus validation and replace BIP crypto placeholders

.dockerignore

@@ -0,0 +1,7 @@
+.git
+target
+fuzz/target
+fuzz/corpus
+fuzz/artifacts
+*.profraw
+tarpaulin-report.json

.github/workflows/ci.yml

@@ -0,0 +1,86 @@
+name: Build and verify
+on:
+  push:
+  pull_request:
+  workflow_dispatch:
+permissions:
+  contents: read
+concurrency:
+  group: ci-${{ github.ref }}
+  cancel-in-progress: true
+jobs:
+  workspace:
+    strategy:
+      fail-fast: false
+      matrix:
+        os: [ubuntu-latest, macos-latest]
+    runs-on: ${{ matrix.os }}
+    steps:
+      - uses: actions/checkout@v4
+      - run: rustup toolchain install 1.88.0 --profile minimal --component rustfmt --component clippy
+      - run: cargo fmt --all -- --check
+      - run: cargo test --workspace --all-features --locked
+      - run: cargo clippy --workspace --all-targets --all-features --locked
+      - run: cargo build --release --locked --package btc-node
+      - run: cargo check --locked --package btc-primitives --no-default-features
+      - run: cargo check --locked --package btc-primitives --no-default-features --features psbt
+      - run: cargo check --locked --package btc-primitives --no-default-features --features descriptor
+      - run: cargo check --locked --package btc-consensus --no-default-features
+      - run: cargo check --locked --package btc-network --no-default-features
+      - run: cargo check --locked --package btc-network --no-default-features --features erlay
+      - run: cargo check --locked --package btc-network --no-default-features --features compact-blocks
+      - run: cargo check --locked --package btc-storage --no-default-features
+      - run: cargo check --locked --package btc-rpc --no-default-features
+  advisories:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - run: rustup toolchain install stable --profile minimal
+      - run: cargo +stable install cargo-audit --locked
+      - run: cargo +stable audit --deny unsound
+  container:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - run: docker build -f devnet/Dockerfile -t btc-rust:ci .
+      - run: docker run --rm btc-rust:ci --help
+  core-interop:
+    runs-on: ubuntu-latest
+    # Includes CPU-heavy Core private signing at the BIP387 999-key maximum.
+    timeout-minutes: 30
+    steps:
+      - uses: actions/checkout@v4
+      - run: rustup toolchain install 1.88.0 --profile minimal
+      - run: cargo build --release --locked --package btc-node --bin btc-node --example legacy_checkpoint_fixture --example exex_fixture
+      - name: Fetch checksum-verified Bitcoin Core v29
+        shell: python
+        run: |
+          import hashlib, os, pathlib, tarfile, urllib.request
+          directory = pathlib.Path(os.environ["RUNNER_TEMP"]) / "btc-core29"
+          directory.mkdir()
+          name = "bitcoin-29.0-x86_64-linux-gnu.tar.gz"
+          base = "https://bitcoincore.org/bin/bitcoin-core-29.0/"
+          with urllib.request.urlopen(base + "SHA256SUMS", timeout=60) as source:
+              manifest = source.read().decode()
+          expected = next(line.split()[0] for line in manifest.splitlines() if line.endswith(name))
+          with urllib.request.urlopen(base + name, timeout=60) as source:
+              data = source.read()
+          assert hashlib.sha256(data).hexdigest() == expected, "Core checksum mismatch"
+          archive = directory / name
+          archive.write_bytes(data)
+          with tarfile.open(archive) as source:
+              source.extractall(directory, filter="data")
+      - run: python3 scripts/check_core_p2p.py --bitcoind "$RUNNER_TEMP/btc-core29/bitcoin-29.0/bin/bitcoind"
+      - run: python3 scripts/check_core_checkpoint.py --bitcoind "$RUNNER_TEMP/btc-core29/bitcoin-29.0/bin/bitcoind"
+      - run: python3 scripts/check_core_http.py --bitcoind "$RUNNER_TEMP/btc-core29/bitcoin-29.0/bin/bitcoind"
+      - run: python3 scripts/check_core_verbose.py --bitcoind "$RUNNER_TEMP/btc-core29/bitcoin-29.0/bin/bitcoind"
+      - run: python3 scripts/check_core_genesis.py --bitcoind "$RUNNER_TEMP/btc-core29/bitcoin-29.0/bin/bitcoind"
+      - run: python3 scripts/check_core_electrum.py --bitcoind "$RUNNER_TEMP/btc-core29/bitcoin-29.0/bin/bitcoind"
+      - run: python3 scripts/check_core_exex.py --bitcoind "$RUNNER_TEMP/btc-core29/bitcoin-29.0/bin/bitcoind"
+      - run: python3 scripts/check_core_fees.py --bitcoind "$RUNNER_TEMP/btc-core29/bitcoin-29.0/bin/bitcoind"
+      - run: python3 scripts/check_core_psbt.py --bitcoind "$RUNNER_TEMP/btc-core29/bitcoin-29.0/bin/bitcoind"
+      - run: python3 scripts/check_core_signer.py --bitcoind "$RUNNER_TEMP/btc-core29/bitcoin-29.0/bin/bitcoind"
+      - run: python3 scripts/check_core_signer.py --taproot-only --bitcoind "$RUNNER_TEMP/btc-core29/bitcoin-29.0/bin/bitcoind"
+      - run: python3 scripts/check_core_signer.py --taproot-script-only --bitcoind "$RUNNER_TEMP/btc-core29/bitcoin-29.0/bin/bitcoind"
+      - run: python3 scripts/check_core_signer.py --hd-only --bitcoind "$RUNNER_TEMP/btc-core29/bitcoin-29.0/bin/bitcoind"
+      - run: python3 scripts/check_erlay.py

.github/workflows/fuzz.yml

@@ -0,0 +1,96 @@
+name: Fuzz smoke tests
+on:
+  push:
+  pull_request:
+  workflow_dispatch:
+  schedule:
+    - cron: "23 4 * * 1"
+permissions:
+  contents: read
+jobs:
+  fuzz:
+    runs-on: ubuntu-latest
+    timeout-minutes: 20
+    strategy:
+      fail-fast: false
+      matrix:
+        target: [fuzz_transaction_decode, fuzz_block_decode, fuzz_script_execute, fuzz_p2p_message, fuzz_bech32_decode, fuzz_varint_decode, fuzz_witness_verify, fuzz_block_template, fuzz_psbt_decode, fuzz_descriptor, fuzz_bip32, fuzz_erlay, fuzz_compact_blocks]
+    steps:
+      - uses: actions/checkout@v4
+      - run: rustup toolchain install nightly --profile minimal
+      - run: cargo +nightly install cargo-fuzz --locked
+      - name: Seed published PSBT vectors
+        if: matrix.target == 'fuzz_psbt_decode'
+        shell: python
+        run: |
+          import json, pathlib
+          corpus = pathlib.Path("fuzz/corpus/fuzz_psbt_decode")
+          corpus.mkdir(parents=True, exist_ok=True)
+          for name in ["bip174-utxo", "bip370", "bip371", "bip341-commitments", "bip32-keys", "psbt-signatures"]:
+              source = pathlib.Path(f"crates/primitives/tests/data/{name}.json")
+              key = "psbt_vectors" if name in ["bip341-commitments", "bip32-keys", "psbt-signatures"] else "vectors"
+              for i, vector in enumerate(json.loads(source.read_text())[key]):
+                  (corpus / f"{name}-{i}").write_bytes(bytes.fromhex(vector["hex"]))
+      - name: Seed public derivation proofs
+        if: matrix.target == 'fuzz_psbt_decode'
+        run: python3 scripts/seed_psbt_derivations.py --corpus fuzz/corpus/fuzz_psbt_decode
+      - name: Seed independently signed threshold wallets
+        if: matrix.target == 'fuzz_psbt_decode'
+        shell: python
+        run: |
+          import json, pathlib
+          corpus = pathlib.Path("fuzz/corpus/fuzz_psbt_decode")
+          for i, vector in enumerate(json.loads(pathlib.Path("crates/primitives/tests/data/taproot-thresholds.json").read_text())["vectors"]):
+              for field in ["partial_psbt", "final_psbt"]:
+                  (corpus / f"threshold-{i}-{field}").write_bytes(bytes.fromhex(vector[field]))
+      - name: Seed independent ECDSA signer cases
+        if: matrix.target == 'fuzz_psbt_decode'
+        shell: python
+        run: |
+          import json, pathlib
+          corpus = pathlib.Path("fuzz/corpus/fuzz_psbt_decode")
+          for i, vector in enumerate(json.loads(pathlib.Path("crates/primitives/tests/data/ecdsa-signer.json").read_text())["vectors"]):
+              (corpus / f"signer-{i}").write_bytes(bytes.fromhex(vector["psbt"]))
+          for i, vector in enumerate(json.loads(pathlib.Path("crates/primitives/tests/data/taproot-key-signer.json").read_text())["vectors"]):
+              (corpus / f"taproot-key-signer-{i}").write_bytes(bytes.fromhex(vector["psbt"]))
+          leaves = json.loads(pathlib.Path("crates/primitives/tests/data/taproot-script-signer.json").read_text())
+          for i, vector in enumerate(leaves["vectors"] + leaves["unsupported"]):
+              (corpus / f"taproot-script-signer-{i}").write_bytes(bytes.fromhex(vector["psbt"]))
+          for i, vector in enumerate(json.loads(pathlib.Path("crates/primitives/tests/data/hd-signer.json").read_text())["vectors"]):
+              (corpus / f"hd-signer-{i}").write_bytes(bytes.fromhex(vector["psbt"]))
+      - name: Seed published descriptors
+        if: matrix.target == 'fuzz_descriptor'
+        shell: python
+        run: |
+          import json, pathlib, sys
+          sys.path.insert(0, "scripts")
+          from check_core_psbt import regtest_descriptor
+          corpus = pathlib.Path("fuzz/corpus/fuzz_descriptor")
+          corpus.mkdir(parents=True, exist_ok=True)
+          vectors = json.loads(pathlib.Path("crates/primitives/tests/data/descriptors.json").read_text())["vectors"]
+          vectors += json.loads(pathlib.Path("crates/primitives/tests/data/private-descriptors.json").read_text())["vectors"]
+          thresholds = json.loads(pathlib.Path("crates/primitives/tests/data/taproot-thresholds.json").read_text())
+          vectors += thresholds["published"] + thresholds["descriptors"]
+          for i, vector in enumerate(vectors):
+              (corpus / f"published-{i}").write_text(vector["descriptor"])
+              translated = regtest_descriptor(vector["descriptor"])
+              if translated != vector["descriptor"]:
+                  (corpus / f"regtest-{i}").write_text(translated)
+      - name: Seed published BIP32 keys
+        if: matrix.target == 'fuzz_bip32'
+        run: python3 scripts/seed_bip32.py --corpus fuzz/corpus/fuzz_bip32
+      - name: Seed independent BIP330 sketches
+        if: matrix.target == 'fuzz_erlay'
+        run: python3 scripts/seed_erlay.py --corpus fuzz/corpus/fuzz_erlay
+      - name: Seed independent BIP152 messages
+        if: matrix.target == 'fuzz_compact_blocks'
+        run: python3 scripts/seed_compact_blocks.py --corpus fuzz/corpus/fuzz_compact_blocks
+      - name: Seed framed BIP152 messages
+        if: matrix.target == 'fuzz_p2p_message'
+        run: python3 scripts/seed_compact_blocks.py --corpus fuzz/corpus/fuzz_p2p_message --p2p
+      - run: cargo +nightly fuzz run ${{ matrix.target }} -- -max_total_time=30 -rss_limit_mb=2048
+      - uses: actions/upload-artifact@v4
+        if: failure()
+        with:
+          name: fuzz-${{ matrix.target }}
+          path: fuzz/artifacts

.gitignore

@@ -2,8 +2,15 @@
 /fuzz/target
 /fuzz/corpus
 /fuzz/artifacts
-Cargo.lock
+*.profraw
+tarpaulin-report.json
 *.swp
 *.swo
 .DS_Store
 .env
+
+# Python interoperability tools
+__pycache__/
+# Per-start local RPC authentication material.
+.cookie
+.cookie.tmp-*

AGENTS.md

@@ -0,0 +1,33 @@
+# btc-rust development
+
+Read `docs/BUILD_PLAN.md` and `docs/REVIEW.md` before selecting repair work.
+The user authorized autonomous repository review, bug fixes, and replacement
+of placeholder implementations. Prioritize BIP transport and wallet crypto,
+then the remaining runtime backends. Resolve routine choices without asking.
+
+- Preserve user changes and existing test artifacts; inspect Git status first.
+- Trace runtime callers and use primary Bitcoin specifications/Core sources.
+- Use independent vectors or meaningful regressions for consensus/crypto changes.
+- A passing self-roundtrip does not establish protocol interoperability.
+- Never replace missing verification with success, fabricated data, or a hash
+  that only resembles a curve key. Report unsupported behavior explicitly.
+- Proposed consensus rules remain explicit experiments; do not activate them
+  on ordinary networks merely because a BIP is marked Complete.
+- Batch each coherent set of changes before running tests, as the user requested
+  to save time. Use `./scripts/check.sh` as the final local gate, with focused
+  follow-up checks only for failures or unresolved concerns. Keep `Cargo.lock`
+  synchronized with dependency changes.
+- Update the build plan with actual acceptance results and remaining work.
+- The user authorized keeping the repository updated without pull requests.
+  Review changes yourself and commit verified milestones to
+  `codex/review-bip-runtime-fixes`. Do not create PRs or require user review.
+  Direct updates to `main` and closing the existing draft are pending explicit
+  authorization after automatic approval review rejected those actions.
+  Preserve unrelated user changes. Use normal pushes; do not force-push.
+  Main integration, releases, deployment and external messages need separate
+  authorization.
+- When SSH authentication is unavailable, use authenticated HTTPS with the
+  GitHub CLI credential helper; never print or embed raw access tokens.
+
+The workspace uses Rust 1.88 and has twelve library/binary crates. The fuzz
+workspace is separate and uses nightly for sanitizer runs.

CLAUDE.md

@@ -5,15 +5,15 @@ A modular Rust Bitcoin full node inspired by reth's architecture.
 ## Build & Test
 
 ```bash
-cargo build          # build all crates
-cargo test           # run all tests (~280+ tests)
+cargo build --workspace --locked # build all crates
+cargo test --workspace --all-features --locked # run all workspace tests
 cargo test -p <crate> # test individual crate
-cargo run -- --help  # CLI help
+cargo run -p btc-node -- --help # CLI help
 ```
 
 ## Architecture
 
-8-crate workspace following reth's patterns:
+12-crate workspace following reth's patterns:
 
 - **btc-primitives** — Hash, encode, script, tx, block, address, amount, bech32. All our own code, no rust-bitcoin dependency.
 - **btc-consensus** — Script engine with real CHECKSIG/secp256k1, sighash (500/500 Core vectors), UTXO processing, header chain management, taproot, segwit witness verification, chain reorgs.