Skip to content

Lower JVM target from 21 to 17 #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kirich1409 wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Lower JVM target from 21 to 17 #233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
657e71d
Lower JVM target from 21 to 17 across all modules
claude Jun 1, 2026
6e03094
Pin Robolectric test to SDK 34 for JDK 17 compatibility
claude Jun 1, 2026
191032c
Update setup-build-env description to Java 17
claude Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/actions/setup-build-env/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
name: Setup Build Environment
description: Checkout code, configure Java 21 (Temurin), and set up Gradle with caching
description: Checkout code, configure Java 17 (Temurin), and set up Gradle with caching

runs:
using: composite
steps:
- uses: actions/setup-java@v4
with:
distribution: temurin
java-version: 21
java-version: 17

- uses: gradle/actions/setup-gradle@v3
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ jobs:
- uses: actions/setup-java@v5
with:
distribution: temurin
java-version: 21
java-version: 17

- uses: gradle/actions/setup-gradle@v6

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/codeql.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
- uses: actions/setup-java@v5
with:
distribution: temurin
java-version: 21
java-version: 17

- uses: gradle/actions/setup-gradle@v6

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ jobs:
- uses: actions/setup-java@v5
with:
distribution: temurin
java-version: 21
java-version: 17

- uses: gradle/actions/setup-gradle@v6

Expand Down
2 changes: 1 addition & 1 deletion core/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ kotlin {
.get()
.toInt()
compilerOptions {
jvmTarget.set(JvmTarget.JVM_21)
jvmTarget.set(JvmTarget.JVM_17)
}
}

Expand Down
4 changes: 2 additions & 2 deletions featured-compose/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ plugins {

kotlin {
explicitApi()
jvmToolchain(21)
jvmToolchain(17)

android {
namespace = "dev.androidbroadcast.featured.compose"
Expand All @@ -25,7 +25,7 @@ kotlin {
.get()
.toInt()
compilerOptions {
jvmTarget.set(JvmTarget.JVM_21)
jvmTarget.set(JvmTarget.JVM_17)
}
}

Expand Down
4 changes: 2 additions & 2 deletions featured-debug-ui/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ plugins {

kotlin {
explicitApi()
jvmToolchain(21)
jvmToolchain(17)

android {
namespace = "dev.androidbroadcast.featured.debugui"
Expand All @@ -24,7 +24,7 @@ kotlin {
.get()
.toInt()
compilerOptions {
jvmTarget.set(JvmTarget.JVM_21)
jvmTarget.set(JvmTarget.JVM_17)
}
}

Expand Down
2 changes: 1 addition & 1 deletion featured-detekt-rules/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ plugins {

kotlin {
explicitApi()
jvmToolchain(21)
jvmToolchain(17)
}

dependencies {
Expand Down
2 changes: 1 addition & 1 deletion featured-gradle-plugin/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ group = "dev.androidbroadcast.featured"

kotlin {
explicitApi()
jvmToolchain(21)
jvmToolchain(17)
}

gradlePlugin {
Expand Down
2 changes: 1 addition & 1 deletion featured-lint-rules/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ plugins {

kotlin {
explicitApi()
jvmToolchain(21)
jvmToolchain(17)
}

dependencies {
Expand Down
4 changes: 2 additions & 2 deletions featured-platform/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ plugins {
}

kotlin {
jvmToolchain(21)
jvmToolchain(17)
explicitApi()

android {
Expand All @@ -23,7 +23,7 @@ kotlin {
.get()
.toInt()
compilerOptions {
jvmTarget.set(JvmTarget.JVM_21)
jvmTarget.set(JvmTarget.JVM_17)
}
}

Expand Down
2 changes: 1 addition & 1 deletion featured-shrinker-tests/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ plugins {
}

kotlin {
jvmToolchain(21)
jvmToolchain(17)
}

dependencies {
Expand Down
4 changes: 2 additions & 2 deletions featured-testing/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ plugins {

kotlin {
explicitApi()
jvmToolchain(21)
jvmToolchain(17)

android {
namespace = "dev.androidbroadcast.featured.testing"
Expand All @@ -22,7 +22,7 @@ kotlin {
.get()
.toInt()
compilerOptions {
jvmTarget.set(JvmTarget.JVM_21)
jvmTarget.set(JvmTarget.JVM_17)
}
}

Expand Down
12 changes: 1 addition & 11 deletions gradle/gradle-daemon-jvm.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,2 @@
#This file is generated by updateDaemonJvm
toolchainUrl.FREE_BSD.AARCH64=https\://api.foojay.io/disco/v3.0/ids/ec7520a1e057cd116f9544c42142a16b/redirect
toolchainUrl.FREE_BSD.X86_64=https\://api.foojay.io/disco/v3.0/ids/4c4f879899012ff0a8b2e2117df03b0e/redirect
toolchainUrl.LINUX.AARCH64=https\://api.foojay.io/disco/v3.0/ids/ec7520a1e057cd116f9544c42142a16b/redirect
toolchainUrl.LINUX.X86_64=https\://api.foojay.io/disco/v3.0/ids/4c4f879899012ff0a8b2e2117df03b0e/redirect
toolchainUrl.MAC_OS.AARCH64=https\://api.foojay.io/disco/v3.0/ids/73bcfb608d1fde9fb62e462f834a3299/redirect
toolchainUrl.MAC_OS.X86_64=https\://api.foojay.io/disco/v3.0/ids/846ee0d876d26a26f37aa1ce8de73224/redirect
toolchainUrl.UNIX.AARCH64=https\://api.foojay.io/disco/v3.0/ids/ec7520a1e057cd116f9544c42142a16b/redirect
toolchainUrl.UNIX.X86_64=https\://api.foojay.io/disco/v3.0/ids/4c4f879899012ff0a8b2e2117df03b0e/redirect
toolchainUrl.WINDOWS.AARCH64=https\://api.foojay.io/disco/v3.0/ids/9482ddec596298c84656d31d16652665/redirect
toolchainUrl.WINDOWS.X86_64=https\://api.foojay.io/disco/v3.0/ids/39701d92e1756bb2f141eb67cd4c660e/redirect
toolchainVersion=21
toolchainVersion=17
4 changes: 2 additions & 2 deletions providers/configcat/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ plugins {
}

kotlin {
jvmToolchain(21)
jvmToolchain(17)
explicitApi()

android {
Expand All @@ -23,7 +23,7 @@ kotlin {
.get()
.toInt()
compilerOptions {
jvmTarget.set(JvmTarget.JVM_21)
jvmTarget.set(JvmTarget.JVM_17)
}
}

Expand Down
4 changes: 2 additions & 2 deletions providers/datastore/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ plugins {
}

kotlin {
jvmToolchain(21)
jvmToolchain(17)
explicitApi()

android {
Expand All @@ -24,7 +24,7 @@ kotlin {
.get()
.toInt()
compilerOptions {
jvmTarget.set(JvmTarget.JVM_21)
jvmTarget.set(JvmTarget.JVM_17)
}
}

Expand Down
4 changes: 2 additions & 2 deletions providers/firebase/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ android {
}

compileOptions {
sourceCompatibility = JavaVersion.VERSION_21
targetCompatibility = JavaVersion.VERSION_21
sourceCompatibility = JavaVersion.VERSION_17
targetCompatibility = JavaVersion.VERSION_17
}

testOptions {
Expand Down
4 changes: 2 additions & 2 deletions providers/javaprefs/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ plugins {

kotlin {
explicitApi()
jvmToolchain(21)
jvmToolchain(17)
compilerOptions {
jvmTarget.set(JvmTarget.JVM_21)
jvmTarget.set(JvmTarget.JVM_17)
}
}

Expand Down
2 changes: 1 addition & 1 deletion providers/nsuserdefaults/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ plugins {
}

kotlin {
jvmToolchain(21)
jvmToolchain(17)
explicitApi()

listOf(
Expand Down
6 changes: 3 additions & 3 deletions providers/sharedpreferences/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ android {
}

compileOptions {
sourceCompatibility = JavaVersion.VERSION_21
targetCompatibility = JavaVersion.VERSION_21
sourceCompatibility = JavaVersion.VERSION_17
targetCompatibility = JavaVersion.VERSION_17
}

testOptions {
Expand All @@ -46,7 +46,7 @@ android {

java {
toolchain {
languageVersion.set(JavaLanguageVersion.of(21))
languageVersion.set(JavaLanguageVersion.of(17))
}
}

Expand Down
2 changes: 1 addition & 1 deletion ...in/dev/androidbroadcast/featured/sharedpreferences/SharedPreferencesProviderConfigTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import org.robolectric.annotation.Config
enum class CheckoutVariant { LEGACY, NEW_SINGLE_PAGE, NEW_MULTI_STEP }

@RunWith(AndroidJUnit4::class)
@Config(manifest = Config.NONE)
@Config(manifest = Config.NONE, sdk = [34])
Comment on lines 29 to +30
class SharedPreferencesProviderConfigTest {
private lateinit var provider: SharedPreferencesProviderConfig

Expand Down
4 changes: 2 additions & 2 deletions sample/android-app/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ android {
}

compileOptions {
sourceCompatibility = JavaVersion.VERSION_21
targetCompatibility = JavaVersion.VERSION_21
sourceCompatibility = JavaVersion.VERSION_17
targetCompatibility = JavaVersion.VERSION_17
}

buildFeatures {
Expand Down
2 changes: 1 addition & 1 deletion sample/desktop/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ plugins {
}

kotlin {
jvmToolchain(21)
jvmToolchain(17)
jvm()

sourceSets {
Expand Down
4 changes: 2 additions & 2 deletions sample/feature-checkout/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ plugins {
}

kotlin {
jvmToolchain(21)
jvmToolchain(17)

android {
namespace = "dev.androidbroadcast.featured.sample.checkout"
Expand All @@ -20,7 +20,7 @@ kotlin {
.get()
.toInt()
compilerOptions {
jvmTarget.set(JvmTarget.JVM_21)
jvmTarget.set(JvmTarget.JVM_17)
}
}

Expand Down
4 changes: 2 additions & 2 deletions sample/feature-promotions/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ plugins {
}

kotlin {
jvmToolchain(21)
jvmToolchain(17)

android {
namespace = "dev.androidbroadcast.featured.sample.promotions"
Expand All @@ -20,7 +20,7 @@ kotlin {
.get()
.toInt()
compilerOptions {
jvmTarget.set(JvmTarget.JVM_21)
jvmTarget.set(JvmTarget.JVM_17)
}
}

Expand Down
4 changes: 2 additions & 2 deletions sample/feature-ui/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ plugins {
}

kotlin {
jvmToolchain(21)
jvmToolchain(17)

android {
namespace = "dev.androidbroadcast.featured.sample.ui"
Expand All @@ -20,7 +20,7 @@ kotlin {
.get()
.toInt()
compilerOptions {
jvmTarget.set(JvmTarget.JVM_21)
jvmTarget.set(JvmTarget.JVM_17)
}
}

Expand Down
4 changes: 2 additions & 2 deletions sample/shared/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ plugins {
}

kotlin {
jvmToolchain(21)
jvmToolchain(17)

android {
namespace = "dev.androidbroadcast.featured.sample"
Expand All @@ -23,7 +23,7 @@ kotlin {
.get()
.toInt()
compilerOptions {
jvmTarget.set(JvmTarget.JVM_21)
jvmTarget.set(JvmTarget.JVM_17)
}
}

Expand Down
Loading