Fix build issues for ADSP boards after kernel bump from 6.12 to 6.18#3338
Closed
ozan956 wants to merge 6 commits into
Closed
Fix build issues for ADSP boards after kernel bump from 6.12 to 6.18#3338ozan956 wants to merge 6 commits into
ozan956 wants to merge 6 commits into
Conversation
The gpio_chip.set callback now expects an int return value, but adsp_gpio_set_value() still returns void. This causes a build failure when assigning the callback to struct gpio_chip.set. Update adsp_gpio_set_value() to return int and return 0 after programming the GPIO state. No functional change is intended. Signed-off-by: Ozan Durgut <ozan.durgut@analog.com>
Newer kernels use timer_container_of() for timer callback container lookup, while from_timer() has been renamed as part of the timer API cleanup. Update the ADI MUSB glue driver to use timer_container_of() in musb_conn_timer_handler(). This matches the current timer API and is consistent with other in-tree MUSB drivers using dev_timer callbacks. This fixes the build failure seen on newer kernels where from_timer() is no longer available. No functional change intended. Link: https://lore.kernel.org/all/aB2X0jCKQO56WdMt@gmail.com/ Signed-off-by: Ozan Durgut <ozan.durgut@analog.com>
ozan956
changed the title
ozan956
changed the title
Allow the ADI MUSB driver to be built with COMPILE_TEST so it can be compile-checked by CI without requiring a target. Signed-off-by: Ozan Durgut <ozan.durgut@analog.com>
Author
|
not sure on 753da5b |
I would make it explicitly depend on COMPILE_TEST so we avoid a potential footgun in the future when adding new platforms. |
Author
Thanks @CalebEthridgeADI, agreed. I switch to |
A COMPILE_TEST build can now enable the ADI MUSB driver without also building the platform-specific provider of set_spu_securep_msec(), which causes a modpost undefined symbol failure. Signed-off-by: Ozan Durgut <ozan.durgut@analog.com>
Allow the ADI ADSP PORT GPIO driver to be built with COMPILE_TEST so it can be compile-checked by CI without requiring a target. Signed-off-by: Ozan Durgut <ozan.durgut@analog.com>
Allow the ADI ADSP PINT irqchip driver to be built with COMPILE_TEST so it can be compile-checked by CI without requiring a target. Signed-off-by: Ozan Durgut <ozan.durgut@analog.com>
Collaborator
|
Jorge has did a bunch of clean-up at the end of last week in #3332. He's converting it from fixups to commits. Then this can be rebased on that once it has been merged |
Author
oh, it covers everything I did then. will close this one. thanks for notifying |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes address two API mismatches surfaced by the newer kernel:
These fixes restore successful builds for ADSP board configurations and unblock CI. No functional change is intended.