Feat: stream live apply logs to audit API - #231
Merged
Conversation
brandonmontijo
marked this pull request as draft
June 30, 2026 15:11
brandonmontijo
marked this pull request as ready for review
July 6, 2026 21:35
aoskotsky-amplify
previously approved these changes
Jul 6, 2026
- Bump version to 0.11.5 (was based on stale 0.11.4/0.10.26) - _chunk_callback now posts to every URL in audit_api_url, matching the multi-URL support added to _post_audit_info on main
- Bump version to 0.11.6 (main independently landed its own 0.11.5) - Layer chunk buffering on top of main's incremental UTF-8 decoder in _execute_command, keeping the decoder's is_eof-after-processing ordering so a final partial multi-byte char still gets chunked
Bump version to 0.11.7 (main independently landed its own 0.11.6). cli.py auto-merged clean this time; only the version bump collided.
brandonmontijo
changed the title
aoskotsky-amplify
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /log_chunkevery 10 lines or 5saudit_api_urlis not set — existing behavior unchangedaudit_api_urlto match main's multi-URL support, and buffering sits on top of main's incremental UTF-8 decoder in_execute_commandso a final partial multi-byte char still flushes to a chunk)Test plan
audit_api_urlat devops-testing, runtf apply, confirm chunks POST successfully_post_log_chunkand the on_chunk buffering/failure-handling inexecute_commandTesting before merge
This feature spans 3 repos — terraform-audit-api#193 and launchpad#130 — and can't be verified in isolation:
log_chunkstable + new endpoints).tf apply/destroyagainst a devops-testing directory withaudit_api_urlpointed at that deploy. ConfirmPOST /log_chunksucceeds and local console output isn't stalling.