fix: write annotations for all value types in serde serializer#1023
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1023 +/- ##
==========================================
+ Coverage 78.97% 79.14% +0.16%
==========================================
Files 140 140
Lines 34822 34911 +89
Branches 34822 34911 +89
==========================================
+ Hits 27502 27630 +128
+ Misses 5245 5194 -51
- Partials 2075 2087 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tgregg
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
In the course of upgrading to rc12, a regression was discovered for the serde feature. Some value types include annotations, and some don't, and it was affecting the enum variant serialization. This ensures that annotations are always included, and adds a bunch more tests to make sure this doesn't happen in future.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.