fix units check for upcoming version of units#45
Merged
Conversation
Owner
|
Thanks @Enchufa2! Sorry for the delayed response, had some family medical issues. PR looks great, I'll merge it in and submit an updated version to CRAN |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported in r-quantities/units#416, there are test failures for this package with the upcoming tokenizer in {units}. In any case, it is not a good idea to grep the deparsed string, because this may change and will change with the new version. This PR makes the check more robust by comparing the units of the input with some known units.