Skip to content

Added constexpr SHA-3 Algorithm Implementation, etc.#903

Open
refvalue wants to merge 7 commits into
alibaba:mainfrom
refvalue:sha3_constexpr
Open

Added constexpr SHA-3 Algorithm Implementation, etc.#903
refvalue wants to merge 7 commits into
alibaba:mainfrom
refvalue:sha3_constexpr

Conversation

@refvalue

@refvalue refvalue commented Feb 14, 2025

Copy link
Copy Markdown

Why

New feature: constexpr SHA-3 Algorithm Implementation.
A fundamental support for byte-array-to-hex-meta_string.

What is changing

Added constexpr SHA-3 Algorithm Implementation.
Added support for conversions from a byte array to a hex meta string.
Added some numeric conversion utilities.
Added some constexpr math functions.

Example

//refvalue::meta_string{"4ACB502EEC4FE8ECDA6E0A8D386FFE6B9B24B8CE2E22F6C8ABC729EC521D361CD883044B720458DCC7472906CC49D9D5"}

constexpr auto hash = to_hexadecimal_meta_string(sha3_digest<sha3_type::sha3_384>( "Whenever you want to, I can help.");

metabeyond added 3 commits February 14, 2025 10:46
Added some numeric conversion utilities.
Added some constexpr math functions.
Added some numeric conversion utilities.
Added some constexpr math functions.
@github-actions

Copy link
Copy Markdown

for detail, goto summary download Artifacts base-ylt-cov-report(base commit coverage report) and ylt-cov-report(current pull request coverage report)

@github-actions

Copy link
Copy Markdown

for detail, goto summary download Artifacts base-ylt-cov-report(base commit coverage report) and ylt-cov-report(current pull request coverage report)

@github-actions

Copy link
Copy Markdown

for detail, goto summary download Artifacts base-ylt-cov-report(base commit coverage report) and ylt-cov-report(current pull request coverage report)

@github-actions

Copy link
Copy Markdown

for detail, goto summary download Artifacts base-ylt-cov-report(base commit coverage report) and ylt-cov-report(current pull request coverage report)

@github-actions

Copy link
Copy Markdown

for detail, goto summary download Artifacts base-ylt-cov-report(base commit coverage report) and ylt-cov-report(current pull request coverage report)

@poor-circle

Copy link
Copy Markdown
Collaborator

Please fix windows ci

@github-actions

Copy link
Copy Markdown

for detail, goto summary download Artifacts base-ylt-cov-report(base commit coverage report) and ylt-cov-report(current pull request coverage report)

@refvalue

Copy link
Copy Markdown
Author

Please fix windows ci

OK all checks have passed

@qicosmos

Copy link
Copy Markdown
Collaborator

I think the code is good.

But namespace is a problem, sha-3 is a util component, i think put it in ylt::util namespace is better, please add util namespace to sha-3.

BTW, refvalue::meta_string should also be ylt::util::meta_string, and then we can unify the namespace. Maybe you can modify it in this PR or next PR.

@refvalue

Copy link
Copy Markdown
Author

I think the code is good.

But namespace is a problem, sha-3 is a util component, i think put it in ylt::util namespace is better, please add util namespace to sha-3.

BTW, refvalue::meta_string should also be ylt::util::meta_string, and then we can unify the namespace. Maybe you can modify it in this PR or next PR.

OK and I will update this PR later.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


metabeyond seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants