Skip to content

fix: redirect personal logins to a valid page #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Thecesar85 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: redirect personal logins to a valid page #333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/algora_web/controllers/user_auth.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,12 +229,12 @@ defmodule AlgoraWeb.UserAuth do

defp maybe_store_return_to(conn), do: conn

def signed_in_path_from_context("personal"), do: ~p"/home"
def signed_in_path_from_context("personal"), do: ~p"/bounties"

def signed_in_path_from_context("preview/" <> ctx) do
case String.split(ctx, "/") do
[_id, repo_owner, repo_name] -> ~p"/go/#{repo_owner}/#{repo_name}"
_ -> ~p"/home"
_ -> ~p"/bounties"
end
end

Expand Down
7 changes: 7 additions & 0 deletions test/algora_web/controllers/user_auth_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,4 +143,11 @@ defmodule AlgoraWeb.UserAuthTest do
assert result == id
end
end

describe "signed_in_path/1" do
test "routes personal context users to the authenticated bounties page" do
assert UserAuth.signed_in_path_from_context("personal") == "/bounties"
assert UserAuth.signed_in_path_from_context("preview/bad/context") == "/bounties"
end
end
end