Skip to content

fix(types): resolve pre-existing type errors on release/2.0 - #632

Merged
alfredo1996 merged 1 commit into
release/2.0from
fix/release-2.0-type-errors
May 1, 2026
Merged

fix(types): resolve pre-existing type errors on release/2.0#632
alfredo1996 merged 1 commit into
release/2.0from
fix/release-2.0-type-errors

Conversation

@alfredo1996

@alfredo1996 alfredo1996 commented Apr 30, 2026

Copy link
Copy Markdown
Owner

Summary

  • Fix implicit any parameter types in plugin-hardening.test.ts (4 occurrences of (d) => d changed to (d: unknown) => d)
  • Add missing chart component stubs (GanttChart, CirclePackingChart, ChoroplethChart) to the @neoboard/components mock in chart-helpers.test.ts, which caused next/dynamic import resolution errors

These are pre-existing type errors on the release/2.0 branch that block CI for all PRs targeting it (#627, #628, #629, #630).

Test plan

  • npx tsc --noEmit -p app/tsconfig.json passes with zero errors
  • npm -w app run test -- --run passes (167 files, 2236 tests, 0 failures)

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Tests
    • Enhanced test infrastructure by adding mocked exports for additional chart component types in plugin test modules, expanding component coverage in validation testing scenarios.
    • Strengthened chart plugin test fixtures by applying explicit and consistent input parameter type annotations to transform callbacks across all validation and warning test cases.

Fix implicit `any` parameter types in plugin-hardening.test.ts and add
missing chart component stubs (GanttChart, CirclePackingChart,
ChoroplethChart) to the chart-helpers.test.ts mock so dynamic imports
resolve correctly.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Apr 30, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 87897b52-5510-4845-815d-57d0d242f22b

📥 Commits

Reviewing files that changed from the base of the PR and between 2b5ca1f and d21eede.

📒 Files selected for processing (2)
  • app/src/lib/__tests__/plugin/chart-helpers.test.ts
  • app/src/plugins/__tests__/plugin-hardening.test.ts

Walkthrough

Test files updated to expand mocked chart component exports and refine transform callback type annotations in plugin test fixtures. Both changes are test-only with no impact on production code or exported APIs.

Changes

Cohort / File(s) Summary
Plugin test fixtures
app/src/lib/__tests__/plugin/chart-helpers.test.ts
Added stubbed exports (GanttChart, CirclePackingChart, ChoroplethChart) to mocked @neoboard/components module for test module resolution.
Plugin hardening tests
app/src/plugins/__tests__/plugin-hardening.test.ts
Updated defineChartPlugin transform callbacks in multiple test fixtures to explicitly type input parameter as unknown.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

pkg:app, area:charts

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main changes: fixing type errors in test files on the release/2.0 branch, which matches the modifications shown in the raw summary.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/release-2.0-type-errors

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 60 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud

Copy link
Copy Markdown

@alfredo1996
alfredo1996 merged commit 96183e8 into release/2.0 May 1, 2026
5 of 13 checks passed
alfredo1996 pushed a commit that referenced this pull request May 1, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
alfredo1996 pushed a commit that referenced this pull request May 1, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
alfredo1996 pushed a commit that referenced this pull request May 1, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
alfredo1996 pushed a commit that referenced this pull request May 1, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
alfredo1996 pushed a commit that referenced this pull request May 1, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
alfredo1996 pushed a commit that referenced this pull request May 1, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@alfredo1996
alfredo1996 deleted the fix/release-2.0-type-errors branch May 16, 2026 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants