fix: address CodeRabbit review findings across PRs #611-#616

[alfredo1996]

Summary

Fixes all Critical and Major CodeRabbit findings from recently merged PRs.

Fixes

#	PR	Severity	Issue	Fix
1	#615	Major	Transform errors fall back silently, user sees wrong data	Amber warning banner: "Data transform failed — showing raw data"
2	#611	Major	Cmd+E bypasses unsaved-changes warning	Route through requestNavigation() guard
3	#611	Major	Cmd+N is browser-reserved (opens new window)	Changed to Cmd+Shift+N
4	#611	Minor	Escape preventDefault fires even when editor closed	disabled: !editorOpen
5	#613	Major	Choropleth dynamic import missing error handling	Added unmount cleanup flag + .catch()
6	#613	Major	Choropleth transform valueKey collapses onto nameKey	Added k !== nameKey guard in fallback

Test plan

• App tests: 167/167 (2224 tests)
• Component tests: 83/83 (1259 tests)
• E2E: 218 passed, 0 failed

🤖 Generated with Claude Code

Summary by CodeRabbit

Release Notes

• Bug Fixes

  • Choropleth maps now properly handle loading failures and component unmounting.
  • Data transformation errors are caught and displayed; raw data shown as fallback.
  • Dashboard keyboard shortcuts now consistently check for unsaved changes before navigation.
  • Improved fallback logic for value column selection in choropleth mapping.

• Documentation

  • Updated keyboard shortcut reference for the "Add Widget" command.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 79aefa7a-bf8f-4e1f-a7d9-b11ebf3c898e

📥 Commits

Reviewing files that changed from the base of the PR and between aafea6b and 283d3d7.

📒 Files selected for processing (5)

• app/src/app/(dashboard)/[id]/edit/page.tsx
• app/src/components/card-container.tsx
• app/src/plugins/choropleth/transform.ts
• component/src/charts/choropleth-chart.tsx
• docs/src/content/docs/guides/keyboard-shortcuts.mdx

---

Walkthrough

Refactors keyboard shortcuts in the dashboard editor (Cmd+E now consults unsaved-changes guard, Cmd+N becomes Cmd+Shift+N), adds error tracking and fallback display for data transformation failures in card rendering, improves value-key selection logic in choropleth transformations, implements cleanup for GeoJSON dynamic imports in choropleth charts, and updates documentation.

Changes

Cohort / File(s)	Summary
Keyboard Shortcuts & Navigation app/src/app/(dashboard)/[id]/edit/page.tsx, docs/src/content/docs/guides/keyboard-shortcuts.mdx	Adjusted keyboard shortcuts: Cmd+E now consults requestNavigation guard before routing, "Add Widget" shortcut changed from Cmd+N to Cmd+Shift+N, Escape handler simplified with conditional disable logic to preserve prior behavior.
Data Transformation Error Handling app/src/components/card-container.tsx	Added error tracking (transformError, liveTransformError) for both chart-specific mapping and applyTransforms steps; falls back to raw/untransformed data with amber warning banner when transform fails.
Choropleth Chart & Transform app/src/plugins/choropleth/transform.ts, component/src/charts/choropleth-chart.tsx	Extended value-key selection fallback in transformToChoroplethData to attempt first available non-nameKey before defaulting to keys[1]; implemented unmount-safe GeoJSON import in ChoroplethChart with cancellation flag and error retry handling.

Possibly related PRs

• feat: query history + keyboard shortcuts hook #611: Directly modifies keyboard shortcut behavior in the same editor page file, involving Cmd+E, Add Widget, and Escape handlers.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~30 minutes

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/coderabbit-review-fixes

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate failed

Failed conditions
25.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud