-
Notifications
You must be signed in to change notification settings - Fork 0
chore: chart polish, E2E speedup, and implementation guide #599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
b1501c5
chore: chart polish, E2E speedup, and app implementation guide
alfredorubin96 d2c9d05
perf(e2e): bump local workers 4→6, smart build skip
alfredorubin96 e5b1f53
fix(widget-editor): show only type label in transform selector trigger
alfredorubin96 1fe1df8
feat(charts): add Gantt chart widget (#601)
alfredorubin96 70536f6
chore(gantt): add demo showcase page, E2E test, vertical scroll
alfredorubin96 9c1da9f
fix(gantt): evaluate styling rules against the specified column field
alfredorubin96 f4fc642
fix(import): complete NeoDash migration coverage and tests
alfredorubin96 d039e83
fix: address CodeRabbit review findings on PR #599
alfredorubin96 3a5db1d
fix(gantt): add Gantt icon to chart type selector
alfredorubin96 7fd4404
fix(gantt): prefix unused renderItem params parameter with underscore
alfredorubin96 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E2E_SKIP_BUILD=0is truthy and will still skip the build.process.env.E2E_SKIP_BUILDis a string, soE2E_SKIP_BUILD=0/false/""(unset via export then overridden) all evaluate truthy (except""). A contributor who flips this to0expecting "off" will unintentionally skip the rebuild and quietly run stale bundles in E2E. Consider parsing it explicitly.♻️ Proposed tweak
📝 Committable suggestion
🤖 Prompt for AI Agents