-
Notifications
You must be signed in to change notification settings - Fork 0
fix: rename UI labels + improve gauge chart styling #471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
fd4008f
fix: rename UI labels + improve gauge chart styling
alfredorubin96 baae3fd
fix(component): replace color palettes with research-backed options
alfredorubin96 2effd3b
fix(ci): prevent connection build TS errors from failing CI steps
alfredorubin96 722b1dc
fix(component): add backwards-compatible aliases for renamed palettes
alfredorubin96 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failing
connectionbuilds are being silently ignored in required CI gates.continue-on-error: trueat Line 57, Line 117, and Line 222 makesnpm -w connection run buildnon-blocking intypecheck,unit-tests, ande2e. That can hide real regressions and let brokenconnectioncode pass merge gates.Suggested fix
- name: Build connection package run: npm -w connection run build - continue-on-error: trueApply this removal in all three jobs.
Based on learnings: Run
npm run buildbefore committing to catch type errors.Also applies to: 115-117, 220-222
🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intentional — the connection package has 16 upstream
neo4j-driver-coretype errors that we can't fix (driver type mismatch). Build emits JS despite errors vianoEmitOnError: false. Thecontinue-on-errorprevents GitHub Actions from failing the step on error annotations. Tracked in #442 for proper resolution when neo4j-driver-core updates.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alfredo1996, understood — that's a clear and reasonable workaround. WithnoEmitOnError: falseletting the JS emit through, and#442tracking the upstream fix,continue-on-error: trueis the right guard here. I'll note this for future reviews.✏️ Learnings added
🧠 Learnings used