Skip to content

feat(app): migrate all 13 remaining charts to plugin system (#220) #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alfredo1996 merged 4 commits into from
Apr 6, 2026
Merged

feat(app): migrate all 13 remaining charts to plugin system (#220) #380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e5248f1
feat(app): migrate all 13 remaining charts to plugin system (#220)
alfredorubin96 Apr 5, 2026
d7972f5
fix: switch from Turbopack to webpack for dev/E2E (#220)
alfredorubin96 Apr 5, 2026
262e4a3
ci: re-trigger flaky graph E2E
alfredorubin96 Apr 6, 2026
a87a3db
refactor: unify plugin callback — single onChartClick, shared PluginP…
alfredorubin96 Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion app/e2e/global-setup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,9 @@ export default async function globalSetup() {
`⏳ Starting Next.js ${serverCmd} server on port ${serverPort}...`,
);
const args = ["next", serverCmd, "--port", String(serverPort)];
if (serverCmd === "dev") args.push("--turbopack");
// Use webpack explicitly — Turbopack (Next.js 16 default) doesn't correctly
// resolve CJS/ESM interop for the @neoboard/connection package at runtime.
if (serverCmd === "dev") args.push("--webpack");
const server = spawn("npx", args, {
cwd: appDir,
stdio: "pipe",
Expand Down
9 changes: 7 additions & 2 deletions app/next.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,13 @@ const nextConfig: NextConfig = {
// Enable source maps in production for E2E coverage collection (nextcov).
productionBrowserSourceMaps: process.env.E2E_COVERAGE === "1",
outputFileTracingRoot: resolve(import.meta.dirname, ".."),
transpilePackages: ["@neoboard/components"],
serverExternalPackages: ["connection", "postgres", "pg"],
transpilePackages: ["@neoboard/components", "@neoboard/connection"],
serverExternalPackages: [
"postgres",
"pg",
"neo4j-driver",
"neo4j-driver-core",
],
webpack: (config, { isServer }) => {
if (isServer) {
// The instrumentation file is compiled in a separate webpack pass that does
Expand Down
2 changes: 1 addition & 1 deletion app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "0.0.1",
"private": true,
"scripts": {
"dev": "next dev --turbopack",
"dev": "next dev --webpack",
"build": "next build --webpack",
"start": "next start",
"lint": "next lint",
Expand Down
Loading
Loading