feat(app): migrate bar/line/pie charts to plugin system (#220) - #379
Conversation
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 0 minutes and 58 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Third PR in the plugin system epic. Migrates the three most-used chart types from the hardcoded switch statement into self-contained plugin files. New plugins: - app/src/plugins/bar.tsx — BarPluginComponent adapter + plugin config - app/src/plugins/line.tsx — LinePluginComponent (includes dual Y-axis, connectNulls, endLabel from #146/#159) - app/src/plugins/pie.tsx — PiePluginComponent (donut, rose, topN) Changes to chart-renderer.tsx: - Removed bar/line/pie/markdown cases from switch (dead code) - Removed now-unused BarChart/LineChart/PieChart dynamic imports - Removed now-unused MarkdownWidget import - Plugin registry lookup intercepts these types before the switch Each plugin reuses existing transforms/validators from chart-registry to stay behaviorally identical during migration. Future PRs will further consolidate options schemas + query hints into plugin configs. Tests added: - 6 bar plugin tests (capabilities, component render, settings passing) - All 1877 app tests pass (+6 new, total +34 since PR 1) Related: #220, epic #221 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
00005ed to
0c1ae54
Compare
|
…mple feat(app): migrate bar/line/pie charts to plugin system (#220)
2 participants
Summary
Third PR in the plugin system epic. Migrates bar/line/pie/markdown from the hardcoded switch into self-contained plugin files.
Stacked on: PR #378 (plugin-driven renderer). Merge that first.
Charts migrated
Renderer cleanup
Pattern
Each plugin reuses existing `transform`/`validate` from `chart-registry` to stay behaviorally identical. Plugin adapter maps `settings → component props` explicitly.
Tests
Related: #220, epic #221
🤖 Generated with Claude Code