feat(component): add DataZoom support for bar and line charts - #170
feat(component): add DataZoom support for bar and line charts#170alfredo1996 wants to merge 3 commits into
Conversation
Add enableDataZoom prop to BaseChart that injects ECharts DataZoom (type: 'inside') on both x and y axes. Users can scroll-to-zoom to explore large datasets. Disabled by default (opt-in via chart options). - New prop: enableDataZoom on BaseChartProps - DataZoom injected into merged options when enabled - Chart option exposed in chart-options-schema for bar/line - 3 new tests for DataZoom behavior Closes #134 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
WalkthroughA new Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Conditionally include seriesName in tooltip formatter to prevent "undefined:" display when series name is not provided - Remove decimalPlaces from bar/line/pie chart option registries where it was registered but never wired up Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
…els, markLine, pie donut) Merges PRs #169, #170, #171, #173, #174 into a single release branch. Resolves merge conflicts in chart-utils.ts, bar-chart.tsx, line-chart.tsx, and chart-options-schema.ts. Includes: - Number formatting for single-value and tooltips (#169) - DataZoom support for bar and line charts (#170) - Auto-rotate and truncate axis labels (#171) - Reference lines (markLine) for bar and line charts (#173) - Donut center text and Top-N grouping for pie chart (#174) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Superseded by consolidated PR #185 (release/chart-improvements) |
…els, markLine, pie donut) Merges PRs #169, #170, #171, #173, #174 into a single release branch. Resolves merge conflicts in chart-utils.ts, bar-chart.tsx, line-chart.tsx, and chart-options-schema.ts. Includes: - Number formatting for single-value and tooltips (#169) - DataZoom support for bar and line charts (#170) - Auto-rotate and truncate axis labels (#171) - Reference lines (markLine) for bar and line charts (#173) - Donut center text and Top-N grouping for pie chart (#174) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>



Summary
Add scroll-to-zoom (DataZoom) as a shared BaseChart prop for bar and line charts. ECharts DataZoom (type: 'inside') enables exploration of large datasets by scrolling to zoom on both axes.
Changes
enableDataZoomonBaseChartProps(types.ts)dataZoom: [{type: 'inside', xAxisIndex: 0}, {type: 'inside', yAxisIndex: 0}]when enabledTest plan
cd component && npm test— 67 suites, 1012 tests passingcd app && npm test— 72 suites, 1260 tests passingnpm run build— cleannpm run lint— cleanCloses #134
🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Tests