test: assert the stale tenant-guard claim stays removed (#1355 follow-up) - #1359
Conversation
…t the new text exists CodeRabbit's finding on #1357, which I merged before reading — my own rule, broken the same way as on #1331 earlier in this session: I checked the comment count and merged in the same command. The finding is right. The test asserted the new path and the two load-bearing caveats are present, but nothing stopped someone reintroducing "Adding a guard is tracked in #1226" alongside them. CLAUDE.md would then contradict itself, which is worse for a reader than either version alone — and worse for an agent, which has no way to tell which sentence is current. Now asserts both directions: the new text present, and both stale phrasings absent. Proven by reintroducing the claim next to the corrected wording and watching the suite go red. Refs #1355 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughThe documentation accuracy test now verifies that ChangesTenant-guard documentation validation
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related issues
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install timed out. The project may have too many dependencies for the sandbox. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
2 participants
What
Follow-up to #1357, which I merged before reading its one CodeRabbit comment — I checked the comment count and merged in the same command. Same slip as on #1331 earlier in this session. The finding was valid.
The finding
The test asserted that the new path reference and the two load-bearing caveats are present. Nothing stopped someone reintroducing "Adding a guard is tracked in #1226" alongside them.
CLAUDE.md would then contradict itself — saying both that the guard is tracked-as-future-work and that it exists at a given path. That's worse for a reader than either version alone, and considerably worse for an agent, which has no way to tell which sentence is current.
Now asserts both directions: new text present, both stale phrasings absent.
Proven by reintroducing the claim next to the corrected wording and watching the suite go red.
Why it generalises
The original test had the shape this codebase keeps getting caught by — asserting the presence of the good state without asserting the absence of the bad one. A doc guard that only checks for the correct sentence will happily pass a document containing both.
Refs #1355
🤖 Generated with Claude Code
Summary by CodeRabbit